Re: RFR: JDK-8317633: Modernize text.testlib.HexDumpReader [v2]

2023-10-09 Thread Lance Andersen
On Fri, 6 Oct 2023 21:07:51 GMT, Justin Lu wrote: >> Please review this PR which cleans up the static test utility class >> _HexDumpReader_. >> >> This cleans up the code by replacing the nested _ByteArrayBuilder_ class >> with _HexFormat_, and simplifies the File processing by using a stream.

Re: RFR: JDK-8317633: Modernize text.testlib.HexDumpReader [v2]

2023-10-07 Thread Hamlin Li
On Fri, 6 Oct 2023 21:07:51 GMT, Justin Lu wrote: >> Please review this PR which cleans up the static test utility class >> _HexDumpReader_. >> >> This cleans up the code by replacing the nested _ByteArrayBuilder_ class >> with _HexFormat_, and simplifies the File processing by using a stream.

Re: RFR: JDK-8317633: Modernize text.testlib.HexDumpReader [v2]

2023-10-06 Thread Naoto Sato
On Fri, 6 Oct 2023 21:07:51 GMT, Justin Lu wrote: >> Please review this PR which cleans up the static test utility class >> _HexDumpReader_. >> >> This cleans up the code by replacing the nested _ByteArrayBuilder_ class >> with _HexFormat_, and simplifies the File processing by using a stream.

Re: RFR: JDK-8317633: Modernize text.testlib.HexDumpReader [v2]

2023-10-06 Thread Justin Lu
On Fri, 6 Oct 2023 18:58:56 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflect review comments > > test/jdk/java/text/testlib/HexDumpReader.java line 65: > >> 63: String hexString = lines

Re: RFR: JDK-8317633: Modernize text.testlib.HexDumpReader [v2]

2023-10-06 Thread Justin Lu
> Please review this PR which cleans up the static test utility class > _HexDumpReader_. > > This cleans up the code by replacing the nested _ByteArrayBuilder_ class with > _HexFormat_, and simplifies the File processing by using a stream. Changes > were tested to ensure that the _text_ tests a

Re: RFR: JDK-8317633: Modernize text.testlib.HexDumpReader [v2]

2023-10-06 Thread Justin Lu
On Fri, 6 Oct 2023 18:57:36 GMT, Lance Andersen wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflect review comments > > test/jdk/java/text/testlib/HexDumpReader.java line 54: > >> 52: >> 53: // Converts a He

Re: RFR: JDK-8317633: Modernize text.testlib.HexDumpReader

2023-10-06 Thread Naoto Sato
On Fri, 6 Oct 2023 17:19:29 GMT, Justin Lu wrote: > Please review this PR which cleans up the static test utility class > _HexDumpReader_. > > This cleans up the code by replacing the nested _ByteArrayBuilder_ class with > _HexFormat_, and simplifies the File processing by using a stream. Chan

Re: RFR: JDK-8317633: Modernize text.testlib.HexDumpReader

2023-10-06 Thread Lance Andersen
On Fri, 6 Oct 2023 17:19:29 GMT, Justin Lu wrote: > Please review this PR which cleans up the static test utility class > _HexDumpReader_. > > This cleans up the code by replacing the nested _ByteArrayBuilder_ class with > _HexFormat_, and simplifies the File processing by using a stream. Chan