On Fri, 6 Oct 2023 21:07:51 GMT, Justin Lu <j...@openjdk.org> wrote: >> Please review this PR which cleans up the static test utility class >> _HexDumpReader_. >> >> This cleans up the code by replacing the nested _ByteArrayBuilder_ class >> with _HexFormat_, and simplifies the File processing by using a stream. >> Changes were tested to ensure that the _text_ tests are still getting >> equivalent ByteArrayInputStreams as before. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Reflect review comments
LGTM ------------- Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16075#pullrequestreview-1662833379
