Re: RFR: JDK-8310453: Update javadoc of java.lang.Object

2023-06-22 Thread Alan Bateman
On Wed, 21 Jun 2023 17:25:19 GMT, Joe Darcy wrote: >> This method has an existing apiNote and implSpec. I suspect Joe meant to add >> this sentence to the apiNote, not the implSpec. > > I did mean to add the cross-reference to Objects.toIdentityString to the > implSpec section since earlier in

Re: RFR: JDK-8310453: Update javadoc of java.lang.Object

2023-06-22 Thread Alan Bateman
On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy wrote: > I had occasion to read over the javadoc sources in java.lang.Object recently > and noticed a few items that could be updated. > > There are some new or expanded API notes referring to methods in > java.util.Objects. I added these references

Re: RFR: JDK-8310453: Update javadoc of java.lang.Object

2023-06-22 Thread Pavel Rappo
On Wed, 21 Jun 2023 11:55:13 GMT, Pavel Rappo wrote: > While it's out of scope of this PR, I note that we could also use the inline > variant of `@return` in those methods of `Objects` that the `Object` refers > to: `hash(Object)`, `hashCode(Object...)`, and `equals(Object, Object)`. In > fact

Re: RFR: JDK-8310453: Update javadoc of java.lang.Object

2023-06-21 Thread Joe Darcy
On Wed, 21 Jun 2023 13:00:38 GMT, Alan Bateman wrote: >> That is, a clear connection to what's being described by that `@implSpec`. > > This method has an existing apiNote and implSpec. I suspect Joe meant to add > this sentence to the apiNote, not the implSpec. I did mean to add the cross-refe

Re: RFR: JDK-8310453: Update javadoc of java.lang.Object

2023-06-21 Thread Chen Liang
On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy wrote: > I had occasion to read over the javadoc sources in java.lang.Object recently > and noticed a few items that could be updated. > > There are some new or expanded API notes referring to methods in > java.util.Objects. I added these references

Re: RFR: JDK-8310453: Update javadoc of java.lang.Object

2023-06-21 Thread Alan Bateman
On Wed, 21 Jun 2023 11:49:54 GMT, Pavel Rappo wrote: >> src/java.base/share/classes/java/lang/Object.java line 260: >> >>> 258: * } >>> 259: * The {@link java.util.Objects#toIdentityString(Object) >>> 260: * Objects.toIdentityString} method returns the string for an >> >> That la

Re: RFR: JDK-8310453: Update javadoc of java.lang.Object

2023-06-21 Thread Pavel Rappo
On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy wrote: > I had occasion to read over the javadoc sources in java.lang.Object recently > and noticed a few items that could be updated. > > There are some new or expanded API notes referring to methods in > java.util.Objects. I added these references

Re: RFR: JDK-8310453: Update javadoc of java.lang.Object

2023-06-21 Thread Pavel Rappo
On Wed, 21 Jun 2023 11:39:43 GMT, Pavel Rappo wrote: >> I had occasion to read over the javadoc sources in java.lang.Object recently >> and noticed a few items that could be updated. >> >> There are some new or expanded API notes referring to methods in >> java.util.Objects. I added these refe

Re: RFR: JDK-8310453: Update javadoc of java.lang.Object

2023-06-21 Thread Pavel Rappo
On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy wrote: > I had occasion to read over the javadoc sources in java.lang.Object recently > and noticed a few items that could be updated. > > There are some new or expanded API notes referring to methods in > java.util.Objects. I added these references

Re: RFR: JDK-8310453: Update javadoc of java.lang.Object

2023-06-21 Thread Pavel Rappo
On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy wrote: > I had occasion to read over the javadoc sources in java.lang.Object recently > and noticed a few items that could be updated. > > There are some new or expanded API notes referring to methods in > java.util.Objects. I added these references

Re: RFR: JDK-8310453: Update javadoc of java.lang.Object

2023-06-20 Thread Roger Riggs
On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy wrote: > I had occasion to read over the javadoc sources in java.lang.Object recently > and noticed a few items that could be updated. > > There are some new or expanded API notes referring to methods in > java.util.Objects. I added these references