On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy <da...@openjdk.org> wrote:

> I had occasion to read over the javadoc sources in java.lang.Object recently 
> and noticed a few items that could be updated.
> 
> There are some new or expanded API notes referring to methods in 
> java.util.Objects. I added these references as apiNote items rather than, 
> say, `@see` tags since  `@see` tag changes would propagate into classes that 
> overrode the methods in questions.
> 
> Changing toString to use an inline `@return` tag has the consequence of 
> omitting a trailing period, "." in the "Returns" section of its javadoc. This 
> also omits  a trailing period in subclasses that use the `@return` statement 
> of Object.toString in their own toString method. Likewise for hashCode.

While it's out of scope of this PR, I note that we could also use the inline 
variant of `@return` in those methods of `Objects` that the `Object` refers to: 
`hash(Object)`, `hashCode(Object...)`, and `equals(Object, Object)`. In fact, I 
think they are crying for it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14567#issuecomment-1600698509

Reply via email to