On Sat, 18 Mar 2023 19:14:09 GMT, Mandy Chung wrote:
>> `ModuleInfoWriter` is not used by the runtime. Move it to the test library
>> as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the
>> test library instead. `ModuleInfoWriter` depends on `jdk.internal.module`
>>
On Mon, 20 Mar 2023 06:57:32 GMT, Jaikiran Pai wrote:
>> test/jdk/java/lang/ModuleTests/AnnotationsTest.java line 61:
>>
>>> 59: * java.base/jdk.internal.module
>>> 60: * @library /test/lib
>>> 61: * @build jdk.test.lib.util.ModuleInfoWriter
>>
>> You don't need to build library cla
On Mon, 20 Mar 2023 01:34:11 GMT, Leonid Mesnik wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move @library after @modules per the recommended ordering
>
> test/jdk/java/lang/ModuleTests/AnnotationsTest.java line
On Sat, 18 Mar 2023 19:14:09 GMT, Mandy Chung wrote:
>> `ModuleInfoWriter` is not used by the runtime. Move it to the test library
>> as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the
>> test library instead. `ModuleInfoWriter` depends on `jdk.internal.module`
>>
On Sat, 18 Mar 2023 19:14:09 GMT, Mandy Chung wrote:
>> `ModuleInfoWriter` is not used by the runtime. Move it to the test library
>> as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the
>> test library instead. `ModuleInfoWriter` depends on `jdk.internal.module`
>>
On Fri, 17 Mar 2023 22:01:46 GMT, Mandy Chung wrote:
> `ModuleInfoWriter` is not used by the runtime. Move it to the test library
> as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the
> test library instead. `ModuleInfoWriter` depends on `jdk.internal.module`
> type
> `ModuleInfoWriter` is not used by the runtime. Move it to the test library
> as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the
> test library instead. `ModuleInfoWriter` depends on `jdk.internal.module`
> types and the Classfile API. Hence `@modules
> java.base
On Fri, 17 Mar 2023 22:01:46 GMT, Mandy Chung wrote:
> `ModuleInfoWriter` is not used by the runtime. Move it to the test library
> as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the
> test library instead. `ModuleInfoWriter` depends on `jdk.internal.module`
> type
On Fri, 17 Mar 2023 22:01:46 GMT, Mandy Chung wrote:
> `ModuleInfoWriter` is not used by the runtime. Move it to the test library
> as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the
> test library instead. `ModuleInfoWriter` depends on `jdk.internal.module`
> type
