On Fri, 17 Mar 2023 22:01:46 GMT, Mandy Chung <mch...@openjdk.org> wrote:

> `ModuleInfoWriter` is not used by the runtime.   Move it to the test library 
> as `jdk.test.lib.util.ModuleInfoWriter`.   The tests are updated to use the 
> test library instead.   `ModuleInfoWriter` depends on `jdk.internal.module` 
> types and the Classfile API.   Hence `@modules 
> java.base/jdk.internal.classfile` and other classfile subpackages are added.

Thanks for moving this to the test lib.

On the tag ordering, the reason some of these tests had @modules before 
@library was just to recommend ordering in the tag tag spec 
(https://openjdk.org/jtreg/tag-spec.html#ORDER).

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.org/jdk/pull/13085

Reply via email to