Re: RFR: JDK-8292576: Improve wording of AccessFlag-related specs [v2]

2022-08-19 Thread Alan Bateman
On Thu, 18 Aug 2022 22:44:53 GMT, Joe Darcy wrote: >> Spec refinement, including acting on some feedback received for JDK-8266670: >> >> https://github.com/openjdk/jdk/pull/7445#discussion_r906846794 > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase.

Re: RFR: JDK-8292576: Improve wording of AccessFlag-related specs [v2]

2022-08-18 Thread Joe Darcy
On Thu, 18 Aug 2022 18:59:30 GMT, Alan Bateman wrote: > If you compare the javadoc for the modifiers vs. accessFlags in each of > ModuleDescriptor, Requires, Exports, and Opens then you'll see what I mean. I > was hoping they could be consistent. Ah, okay. Pushed docs updated as suggested for

Re: RFR: JDK-8292576: Improve wording of AccessFlag-related specs [v2]

2022-08-18 Thread Joe Darcy
> Spec refinement, including acting on some feedback received for JDK-8266670: > > https://github.com/openjdk/jdk/pull/7445#discussion_r906846794 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brough

Re: RFR: JDK-8292576: Improve wording of AccessFlag-related specs

2022-08-18 Thread Alan Bateman
On Thu, 18 Aug 2022 18:16:21 GMT, Joe Darcy wrote: >> src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 217: >> >>> 215: /** >>> 216: * {@return an unmodifiable set of the module {@linkplain >>> AccessFlag >>> 217: * requires flags}, possibly empt

Re: RFR: JDK-8292576: Improve wording of AccessFlag-related specs

2022-08-18 Thread Joe Darcy
On Thu, 18 Aug 2022 06:56:53 GMT, Alan Bateman wrote: >> Spec refinement, including acting on some feedback received for JDK-8266670: >> >> https://github.com/openjdk/jdk/pull/7445#discussion_r906846794 > > src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 217: > >> 215:

Re: RFR: JDK-8292576: Improve wording of AccessFlag-related specs

2022-08-18 Thread Alan Bateman
On Thu, 18 Aug 2022 05:05:33 GMT, Joe Darcy wrote: > Spec refinement, including acting on some feedback received for JDK-8266670: > > https://github.com/openjdk/jdk/pull/7445#discussion_r906846794 src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 217: > 215: /** >