Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v11]

2025-05-10 Thread Vicente Romero
On Sat, 10 May 2025 19:36:52 GMT, Chen Liang wrote: > As much as I dislike streams, I think we will probably keep them for their > conciseness except this one, which made things less concise. thanks! committed - PR Comment: https://git.openjdk.org/jdk/pull/24746#issuecomment-28691

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v11]

2025-05-10 Thread Archie Cobbs
On Sat, 10 May 2025 19:32:16 GMT, Chen Liang wrote: >> Vicente Romero has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - additional changes from Archie >> - removing dead code > > src/jdk.compiler/share/classes/com/sun/tools/javac/code/L

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v11]

2025-05-10 Thread Chen Liang
On Sat, 10 May 2025 16:39:38 GMT, Vicente Romero wrote: >> This PR is defining a new internal annotation, >> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and >> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation >> that an argument to a given method or

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v11]

2025-05-10 Thread Vicente Romero
> This PR is defining a new internal annotation, > `@jdk.internal.RequiresIdentity`, with target types PARAMETER and > TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation > that an argument to a given method or constructor parameter will be an object > with a unique ident