On Sat, 10 May 2025 16:39:38 GMT, Vicente Romero <vrom...@openjdk.org> wrote:
>> This PR is defining a new internal annotation, >> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and >> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation >> that an argument to a given method or constructor parameter will be an >> object with a unique identity, not an instance of a value-based class; or >> that the type argument to a given type parameter will not be a value-based >> class type. >> >> For more details please refer to the complete description in the >> corresponding JIRA entry [1] >> >> TIA >> >> [1] https://bugs.openjdk.org/browse/JDK-8354556 > > Vicente Romero has updated the pull request incrementally with two additional > commits since the last revision: > > - additional changes from Archie > - removing dead code As much as I dislike streams, I think we will probably keep them for their conciseness except this one, which made things less concise. src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java line 422: > 420: ArrayList<String> optionList = new ArrayList<>(1 + > aliases.length); > 421: optionList.add(option); > 422: Stream.of(aliases).forEach(optionList::add); Suggestion: Collections.addAll(optionList, aliases); ------------- PR Review: https://git.openjdk.org/jdk/pull/24746#pullrequestreview-2831052002 PR Review Comment: https://git.openjdk.org/jdk/pull/24746#discussion_r2083275193
