On Mon, 19 May 2025 14:35:40 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
On Mon, 19 May 2025 14:35:40 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
On Mon, 19 May 2025 14:35:40 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Thu, 15 May 2025 22:32:12 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
On Thu, 15 May 2025 22:32:12 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Wed, 14 May 2025 18:27:18 GMT, Jan Lahoda wrote:
>> Vicente Romero has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 34 commits:
>>
>> - Merge branch 'master' into JDK-8354556
>> - Update src/jdk.compiler/share/classes/com/sun/
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Wed, 14 May 2025 18:25:26 GMT, Jan Lahoda wrote:
>> Vicente Romero has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 34 commits:
>>
>> - Merge branch 'master' into JDK-8354556
>> - Update src/jdk.compiler/share/classes/com/sun/
On Wed, 14 May 2025 18:23:09 GMT, Jan Lahoda wrote:
>> Vicente Romero has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 34 commits:
>>
>> - Merge branch 'master' into JDK-8354556
>> - Update src/jdk.compiler/share/classes/com/sun/
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Tue, 13 May 2025 19:36:11 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
On Tue, 13 May 2025 19:36:11 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
On Fri, 18 Apr 2025 02:25:24 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 34 commits:
>>
>> - Merge branch 'master' into JDK-8354556
>> - Update src/jdk.compiler/share/classes/com/sun/
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Sat, 10 May 2025 20:28:39 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
On Sat, 10 May 2025 20:38:36 GMT, Archie Cobbs wrote:
> FYI, this issue now effectively fixes [JDK-7004476 Lint.LintCategory should
> support aliases](https://bugs.openjdk.org/browse/JDK-7004476), which happened
> to be closed as "Rejected" on Monday. Not sure if anything needs to be done.
I g
On Sat, 10 May 2025 20:28:39 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
On Sat, 10 May 2025 19:36:52 GMT, Chen Liang wrote:
> As much as I dislike streams, I think we will probably keep them for their
> conciseness except this one, which made things less concise.
thanks! committed
-
PR Comment: https://git.openjdk.org/jdk/pull/24746#issuecomment-28691
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Sat, 10 May 2025 19:32:16 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - additional changes from Archie
>> - removing dead code
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/L
On Sat, 10 May 2025 16:39:38 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
On Sat, 10 May 2025 16:03:37 GMT, Vicente Romero wrote:
> > heh, I was doing the same, thanks anyway :)
>
> Awesome, thanks!
>
> Apologies for the mid-air collision :) I've merged your latest merge into my
> merge, leaving just a few minor fixes.
thanks!
-
PR Comment: https://gi
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Sat, 10 May 2025 15:31:45 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
On Sat, 10 May 2025 15:31:45 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
On Sat, 10 May 2025 15:41:18 GMT, Archie Cobbs wrote:
> > heh, I was doing the same, thanks anyway :)
>
> Awesome, thanks!
>
> Apologies for the mid-air collision :) I've merged your latest merge into my
> merge, leaving just a few minor fixes.
thanks!
-
PR Comment: https://git.
On Sat, 10 May 2025 15:31:17 GMT, Chen Liang wrote:
> Thanks. Looks good, but the Lint to all option names streaming can be
> replaced by the static map lookup/iteration.
Good point... I prototyped that in commit be160a3261b.
-
PR Comment: https://git.openjdk.org/jdk/pull/24746#is
On Sat, 10 May 2025 15:35:16 GMT, Vicente Romero wrote:
> heh, I was doing the same, thanks anyway :)
Awesome, thanks!
Apologies for the mid-air collision :) I've merged your latest merge into my
merge, leaving just a few minor fixes.
-
PR Comment: https://git.openjdk.org/jdk/pul
On Sat, 10 May 2025 15:31:17 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixing bugs, removing dead code
>
> Thanks. Looks good, but the Lint to all option names streaming can be
> replaced b
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Sat, 10 May 2025 15:24:52 GMT, Archie Cobbs wrote:
>>> That's why I was offering my existing patch which basically does that
>>> already. But it's OK to wait if you prefer.
>>
>> Sure, I think vicente is open to patches and PRs to his fork. And I can help
>> review; just remember to @liach.
On Fri, 9 May 2025 20:28:12 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or c
On Fri, 9 May 2025 22:39:19 GMT, Chen Liang wrote:
> Sure, I think vicente is open to patches and PRs to his fork. And I can help
> review; just remember to @liach.
OK thanks. I've rebased my changes on @vicente-romero-oracle's branch to simply
any evaluation. [Here's the
diff](https://github
On Thu, 8 May 2025 18:55:34 GMT, Vicente Romero wrote:
>> Vicente Romero has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 26 commits:
>>
>> - Merge branch 'master' into JDK-8354556
>> - addressing review comment
>> - changes to
On Fri, 9 May 2025 21:24:58 GMT, Archie Cobbs wrote:
> That's why I was offering my existing patch which basically does that
> already. But it's OK to wait if you prefer.
Sure, I think vicente is open to patches and PRs to his fork. And I can help
review; just remember to @liach.
On Fri, 9 May 2025 21:09:46 GMT, Chen Liang wrote:
> I think if we do that, we should encapsulate `option` and move all access,
> such as `option.isSet`, to dedicated methods on `LintCategory`. We are a bit
> short on time for this, so IMO our best approach is to open a followup issue
> that w
On Fri, 9 May 2025 21:06:09 GMT, Archie Cobbs wrote:
> Do we care about that? If so then we might want to implement a proper fix for
> lint aliases as a separate pre-requisite to this issue.
I think if we do that, we should encapsulate `option` and move all access, such
as `option.isSet`, to d
On Fri, 9 May 2025 20:25:40 GMT, Vicente Romero wrote:
> I was working on something in this line too, just pushed the patch
Looks reasonable, a couple of comments...
Can't `LintCategory.alias` be `final`? If so I think this obviates the patch to
`DetectMutableStaticFields.java`.
This is not a
On Fri, 9 May 2025 20:28:12 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or c
On Fri, 9 May 2025 20:43:46 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixing bugs, removing dead code
>
> make/langtools/src/classes/build/tools/symbolgenerator/CreateSymbols.java
> line 22
On Fri, 9 May 2025 20:28:12 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or c
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Thu, 8 May 2025 18:55:34 GMT, Vicente Romero wrote:
>> Vicente Romero has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 26 commits:
>>
>> - Merge branch 'master' into JDK-8354556
>> - addressing review comment
>> - changes to
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Fri, 9 May 2025 14:35:38 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or c
On Fri, 9 May 2025 14:35:38 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or c
On Fri, 9 May 2025 14:35:38 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or c
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Thu, 8 May 2025 13:33:45 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or c
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Mon, 5 May 2025 09:40:16 GMT, Yudi Zheng wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes to test
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java line 669:
>
>> 667:
>> 668:
On Fri, 2 May 2025 19:44:31 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or c
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Fri, 18 Apr 2025 00:06:26 GMT, Vicente Romero wrote:
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or cons
On Fri, 18 Apr 2025 02:32:06 GMT, Chen Liang wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or cons
61 matches
Mail list logo
