On Thu, 17 Apr 2025 23:06:04 GMT, Justin Lu wrote:
>> Please review this PR which improves the _ValidateISO4217_ Currency test by
>> adding testing of future currencies after the transition date.
>>
>> This is done by creating a patched version of Currency that replaces
>> `System.currentTimeM
> Please review this PR which improves the _ValidateISO4217_ Currency test by
> adding testing of future currencies after the transition date.
>
> This is done by creating a patched version of Currency that replaces
> `System.currentTimeMillis()` calls with a mocked value equivalent to
> `Long.
On Thu, 17 Apr 2025 00:15:47 GMT, Naoto Sato wrote:
>> Please review this PR which improves the _ValidateISO4217_ Currency test by
>> adding testing of future currencies after the transition date.
>>
>> This is done by creating a patched version of Currency that replaces
>> `System.currentTime
On Thu, 17 Apr 2025 22:05:31 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> simple/special case in check invocation
>
> test/jdk/java/util/Currency/ValidateISO4217.java line 203:
>
>> 201: Co
> Please review this PR which improves the _ValidateISO4217_ Currency test by
> adding testing of future currencies after the transition date.
>
> This is done by creating a patched version of Currency that replaces
> `System.currentTimeMillis()` calls with a mocked value equivalent to
> `Long.
On Thu, 17 Apr 2025 21:35:08 GMT, Justin Lu wrote:
>> Please review this PR which improves the _ValidateISO4217_ Currency test by
>> adding testing of future currencies after the transition date.
>>
>> This is done by creating a patched version of Currency that replaces
>> `System.currentTimeM
> Please review this PR which improves the _ValidateISO4217_ Currency test by
> adding testing of future currencies after the transition date.
>
> This is done by creating a patched version of Currency that replaces
> `System.currentTimeMillis()` calls with a mocked value equivalent to
> `Long.
On Thu, 17 Apr 2025 00:15:47 GMT, Naoto Sato wrote:
> > As the test tracks the ISO 4217 data, manual testing of this change can be
> > done by modifying the cut-over year from 2025 to 2026 for the
> > `CW=ANG;2025-04-01-04-00-00;XCG` entry for both the JDK and test data.
>
> Would it be possib
On Wed, 16 Apr 2025 23:06:19 GMT, Justin Lu wrote:
> As the test tracks the ISO 4217 data, manual testing of this change can be
> done by modifying the cut-over year from 2025 to 2026 for the
> `CW=ANG;2025-04-01-04-00-00;XCG` entry for both the JDK and test data.
Would it be possible to use `
