On Thu, 20 Mar 2025 09:52:02 GMT, Aleksey Shipilev wrote:
> See the bug for rationale.
>
> This goal for this improvement is to be easily backportable, so we can catch
> up with update releases. As such, it does a few borderline-trivial changes,
> and _does not_ change the jspawnhelper protoc
On Thu, 20 Mar 2025 11:00:01 GMT, Severin Gehwolf wrote:
>> src/java.base/unix/native/jspawnhelper/jspawnhelper.c line 160:
>>
>>> 158:
>>> 159: if (strcmp(argv[1], VERSION_STRING) != 0) {
>>> 160: fprintf(stdout, "Incorrect Java version: %s\n", argv[1]);
>>
>> Don't you want to ke
On Thu, 20 Mar 2025 10:51:08 GMT, Severin Gehwolf wrote:
>> See the bug for rationale.
>>
>> This goal for this improvement is to be easily backportable, so we can catch
>> up with update releases. As such, it does a few borderline-trivial changes,
>> and _does not_ change the jspawnhelper pr
On Thu, 20 Mar 2025 09:52:02 GMT, Aleksey Shipilev wrote:
> See the bug for rationale.
>
> This goal for this improvement is to be easily backportable, so we can catch
> up with update releases. As such, it does a few borderline-trivial changes,
> and _does not_ change the jspawnhelper protoc
On Thu, 20 Mar 2025 11:42:15 GMT, Aleksey Shipilev wrote:
> I have been thinking about this for the last several days, and I think we
> should be doing this relaxation consistently everywhere. Honestly, I don't
> expect the all distro issues to be fixed/deployed in the field before JDK 25
> GA
On Thu, 20 Mar 2025 09:52:02 GMT, Aleksey Shipilev wrote:
> See the bug for rationale.
>
> This goal for this improvement is to be easily backportable, so we can catch
> up with update releases. As such, it does a few borderline-trivial changes,
> and _does not_ change the jspawnhelper protoc
On Thu, 20 Mar 2025 11:09:34 GMT, Alan Bateman wrote:
> In any case, I don't think we should change main line as it currently targets
> JDK 25 so won't GA for 6 months. Maybe there is a case to re-examine in the
> update releases where the jspawnhelper checks were back ported but I think we
>
On Thu, 20 Mar 2025 09:52:02 GMT, Aleksey Shipilev wrote:
> See the bug for rationale.
>
> This goal for this improvement is to be easily backportable, so we can catch
> up with update releases. As such, it does a few borderline-trivial changes,
> and _does not_ change the jspawnhelper protoc
On Thu, 20 Mar 2025 10:53:49 GMT, Aleksey Shipilev wrote:
> I used to think the same, but with every new report we are seeing, I think we
> need to re-evaluate. From the bug: "To emphasize, this is not a bugfix, as
> version checks still a valid thing to do. This is merely a pragmatic
> conces
On Thu, 20 Mar 2025 10:09:31 GMT, Alan Bateman wrote:
> Something is very broken if the JDK is being overridden while in use.
Yes, that was the original thinking for jspawnhelper version checks.
> So I don't think I agree that relaxing the check is the right thing to do,
> it's not fixing the
10 matches
Mail list logo
