On Tue, 3 Dec 2024 14:53:41 GMT, Eirik Bjørsnøs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove an obsolete comment related to long ago removed useNewThrowable
>
> src/java.base/share/classes/java/lang/StackS
On Tue, 3 Dec 2024 14:45:22 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove an obsolete comment r
On Tue, 3 Dec 2024 14:45:22 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove an obsolete comment r
On Tue, 3 Dec 2024 09:40:39 GMT, Eirik Bjørsnøs wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into 8345325-sm-remove-getpropertyaction
>> - Remove unused import o
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Remove an obsolete comment related to long ago removed useNewThrowable
-
Changes
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 15 commits:
>
> -
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 15 commits:
>
> -
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 15 commits:
>
> -
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 15 commits:
>
> -
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 15 commits:
>
> -
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 15 commits:
- Merge branch 'master' into 8345325-sm-remove-getpropertyaction
-
On Mon, 2 Dec 2024 22:02:54 GMT, Sean Mullan wrote:
> This includes a lot of changes already integrated in 8344397. Is that normal?
I believe this is due to GitHub's diff rendering when it detects a merge
conflict. It should go away once the conflict is fixed.
-
PR Comment: https
On Mon, 2 Dec 2024 20:47:16 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Remove unused import of Pr
On Mon, 2 Dec 2024 20:47:16 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Remove unused import of Pr
On Mon, 2 Dec 2024 20:40:23 GMT, Eirik Bjørsnøs wrote:
>> Yes, with Sean's changes in #22418, GetPropertyAction et.al. is deleted.
>
> @RogerRiggs Alan may have referred to the import of `java.util.Properties`.
Right, thanks
-
PR Review Comment: https://git.openjdk.org/jdk/pull/224
On Mon, 2 Dec 2024 20:28:13 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java line
>> 710:
>>
>>> 708:
>>> 709: static {
>>> 710: Properties props = GetPropertyAction.privilegedGetProperties();
>>
>> This is probably the last usage of
On Mon, 2 Dec 2024 20:44:05 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Remove unused import of Pr
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Roger Riggs has updated the pull request incrementally with two additional
commits since the last revision:
- Remove unused import of Properties
- Update copyrights
Remove jdk/sun/security/action/Ge
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22497#pullrequestreview-2473841217
On Mon, 2 Dec 2024 20:19:23 GMT, Alan Bateman wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java line
> 710:
>
>> 708:
>> 709: static {
>> 710: Properties p
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java line 710:
> 708:
> 709: static {
> 710: Properties props = GetPrope
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Changes Look Good Roger
-
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22497#pullrequestreview-2
22 matches
Mail list logo
