On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses. >> >> Dependent on PR#22418 > > Roger Riggs has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 15 commits: > > - Merge branch 'master' into 8345325-sm-remove-getpropertyaction > - Remove unused import of Properties > - Update copyrights > Remove jdk/sun/security/action/Generify test > - 8345325: SM cleanup of GetPropertyAction in java.base > Remove use of GetPropertyAction > Remove sun/security/action/GetPropertyAction.java > - Remove PutAllAction and GetBooleanAction classes as there are no more > dependencies. > Move GetPropertyAction.privilegedGetTimeoutProp and > privilegedGetBooleanProp > methods to sun.security.util.SecurityProperties and rename them. > - Replace remaining calls to SecurityProperties.privilegedGetOverridable() > with SecurityProperties.getOverridableProperty() and remove > privilegedGetOverridable(). > - Merge > - Remove doPrivileged calls. > - Remove dependency on SecurityConstants.ALL_PERMISSION from java.lang.Class. > - Remove permission text from comments in Provider.java. > - ... and 5 more: https://git.openjdk.org/jdk/compare/3a3bcd53...4c855033 src/java.base/share/classes/java/lang/StackStreamFactory.java line 87: > 85: * For Throwable to use StackWalker, set useNewThrowable to true. > 86: * Performance work and extensive testing is needed to replace the > 87: * VM built-in backtrace filled in Throwable with the StackWalker. This leftover comment used to belong to the `useNewThrowable` field which was removed in merge commit 4db74fef1e73c008d044c681d26c7444b2245316 back in 2017. You may consider removing it, since it now seems to belong to the `isDebug` field, which is not the case. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22497#discussion_r1867366019
