On Tue, 3 Dec 2024 06:12:13 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Tue, 3 Dec 2024 09:03:20 GMT, Jaikiran Pai wrote:
> Although trivial, there are some changes to files from the serviceability
> area. So it would be good if someone from that area could review this too.
Yes, looks good. I will update https://github.com/openjdk/jdk/pull/22478 to
avoid the c
On Tue, 3 Dec 2024 06:12:13 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Tue, 3 Dec 2024 06:14:31 GMT, Jaikiran Pai wrote:
>> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java
>> line 68:
>>
>>> 66: try (Stream lines = Files.lines(filePath)) {
>>> 67: Optional firstLine = lines.findFirst();
>>> 68: re
On Tue, 3 Dec 2024 06:12:13 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Tue, 3 Dec 2024 06:12:13 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Mon, 2 Dec 2024 18:54:33 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/misc/InnocuousThread.java line 31:
>>
>>> 29:
>>> 30: /**
>>> 31: * A thread that has no permissions, is not a member of any user-defined
>>
>> I think you can also remove the words "has no permis
On Mon, 2 Dec 2024 17:47:57 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 13 commits:
>>
>> - merge latest from master branch
>> - remove changes to
>> src/java.base/unix/classes/sun/s
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> changes are trivial. The
> `src/java.base/linux/classes/jdk/
On Mon, 2 Dec 2024 14:25:12 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove unused import
>> - replace remaining Paths.get() with Path.of() in the updated files
>
> src/java.base/linux/c
On Mon, 2 Dec 2024 13:43:41 GMT, Severin Gehwolf wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - remove unnecessary space
>> - Path.of() instead of Paths.get()
>> - fix formatting of try-with-resources in Cgro
On Mon, 2 Dec 2024 16:11:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Mon, 2 Dec 2024 14:24:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Mon, 2 Dec 2024 14:03:10 GMT, Jaikiran Pai wrote:
>> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java
>> line 70:
>>
>>> 68: String line = bufferedReader.readLine();
>>> 69: return line;
>>> 70: } catch (IOException e) {
>>
>>
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> changes are trivial. The
> `src/java.base/linux/classes/jdk/
On Mon, 2 Dec 2024 14:17:10 GMT, Severin Gehwolf wrote:
> cgroups changes look good. Haven't looked at the other bits.
Thank you Severin.
> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java
> line 29:
>
>> 27: package jdk.internal.platform;
>> 28:
>> 29: import
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> changes are trivial. The
> `src/java.base/linux/classes/jdk/
On Mon, 2 Dec 2024 14:07:45 GMT, Severin Gehwolf wrote:
>> Is the catch for `UncheckedIOException` due to some previously known failure
>> resulting in the use of these APIs?
>
> Without using `Files.lines()` no `UncheckedIOException` would be thrown. Just
> `IOException` and `null` returned. T
On Mon, 2 Dec 2024 13:06:05 GMT, Severin Gehwolf wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Path.of() instead of Paths.get() in CgroupV2Subsystem.java
>
> src/java.base/linux/classes/jdk/internal/platform/cgro
On Mon, 2 Dec 2024 16:11:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Mon, 2 Dec 2024 12:43:20 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - remove unnecessary space
>> - Path.of() instead of Paths.get()
>> - fix formatting of try-with-resources in CgroupS
On Mon, 2 Dec 2024 13:39:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> changes are trivial. The
> `src/java.base/linux/classes/jdk/
On Mon, 2 Dec 2024 16:11:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Mon, 2 Dec 2024 18:48:27 GMT, Sean Mullan wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 13 commits:
>>
>> - merge latest from master branch
>> - remove changes to
>> src/java.base/unix/classes/sun/se
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> changes are trivial. The
> `src/java.base/linux/classes/jdk/
On Mon, 2 Dec 2024 15:42:37 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove changes to
>> src/java.base/unix/classes/sun/security/provider/NativePRNG.java
>
> src/java.base/unix/classes/su
On Mon, 2 Dec 2024 14:24:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Mon, 2 Dec 2024 14:16:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> changes are trivial. The
> `src/java.base/linux/classes/jdk/
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> changes are trivial. The
> `src/java.base/linux/classes/jdk/
On Mon, 2 Dec 2024 12:42:47 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - remove unnecessary space
>> - Path.of() instead of Paths.get()
>> - fix formatting of try-with-resources in CgroupS
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> changes are trivial. The
> `src/java.base/linux/classes/jdk/
On Mon, 2 Dec 2024 12:13:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> change
On Mon, 2 Dec 2024 12:13:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> change
35 matches
Mail list logo
