On Mon, 2 Dec 2024 16:11:57 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >> changes are trivial. The >> `src/java.base/linux/classes/jdk/internal/platform/CgroupUtil.java` used to >> expose utility methods for dealing with SecurityManager permissions and it >> was called from a few places. That class is no longer needed with the clean >> up done in this PR. >> >> No new tests have been introduced and tier testing is currently in progress. > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 13 commits: > > - merge latest from master branch > - remove changes to > src/java.base/unix/classes/sun/security/provider/NativePRNG.java > - remove unused import > - replace remaining Paths.get() with Path.of() in the updated files > - Update > src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java > > Co-authored-by: Severin Gehwolf <jerb...@gmail.com> > - Update > src/java.base/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2Subsystem.java > > Co-authored-by: Severin Gehwolf <jerb...@gmail.com> > - Path.of() instead of Paths.get() in CgroupV2Subsystem.java > - remove unnecessary space > - Path.of() instead of Paths.get() > - fix formatting of try-with-resources in CgroupSubsystemController.java > - ... and 3 more: https://git.openjdk.org/jdk/compare/30b8bbe2...9baa279b Good cleanup! Changes to logger + net look fine. src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java line 68: > 66: try (Stream<String> lines = Files.lines(filePath)) { > 67: Optional<String> firstLine = lines.findFirst(); > 68: return firstLine.orElse(null); you could probably just: return lines.findFirst().orElse(null); unless the local variable is needed or type inference? ------------- PR Review: https://git.openjdk.org/jdk/pull/22478#pullrequestreview-2473460631 PR Review Comment: https://git.openjdk.org/jdk/pull/22478#discussion_r1866322400
