On Mon, 23 Dec 2024 13:18:09 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
On Mon, 23 Dec 2024 13:18:09 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
On Mon, 23 Dec 2024 13:18:09 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
On Mon, 23 Dec 2024 13:18:09 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
On Tue, 24 Dec 2024 11:46:44 GMT, Taizo Kurashige wrote:
> After applying the patch you provided, I confirmed that the test using the
> mounted ISO file passes. I'm sorry I haven't been able to see the results of
> the physical CD drive test myself, but I think I'll commit this patch. Thank
>
On Wed, 18 Dec 2024 23:02:34 GMT, Brian Burkhalter wrote:
> So I don't see any difference between a physical drive and a mounted ISO file
> with respect to this test.
I understood that the test fails on both the physical CD drive and the mounted
ISO file.
In my environment, testing with a mou
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information
> about the size of the CD-ROM drive.
> Ge
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information
> about the size of the CD-ROM drive.
> Ge
On Fri, 13 Dec 2024 10:10:16 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
On Tue, 17 Dec 2024 23:40:58 GMT, Taizo Kurashige wrote:
> Could you tell me what the result would be if you tested using a virtual
> drive with the iso file mounted instead of a physical CD drive and disk?
I mounted an ISO file on `D:`. Command line execution of `df` in Cygwin:
$ df D:\\
File
On Wed, 18 Dec 2024 00:30:37 GMT, Brian Burkhalter wrote:
> Also, can you tell me the version of Cygwin (output of “uname -r”)?
$ uname -r
3.4.8-1.x86_64
-
PR Comment: https://git.openjdk.org/jdk/pull/21799#issuecomment-2552410033
On Tue, 17 Dec 2024 23:40:58 GMT, Taizo Kurashige wrote:
> I'm sorry, but I would like to know what the output looks like when you run
> the df command on a virtual drive with the iso file mounted.
I can investigate that tomorrow, Pacific Time. As I recall, an earlier version
_did_ work with t
On Fri, 13 Dec 2024 21:10:31 GMT, Brian Burkhalter wrote:
> It fails for me on a Windows 11 laptop with an external CD drive with a CD
> inserted. On Cygwin the df command gives:
Could you tell me what the result would be if you tested using a virtual drive
with the iso file mounted instead of
On Fri, 13 Dec 2024 10:10:53 GMT, Taizo Kurashige wrote:
>> test/jdk/java/io/File/GetXSpace.java line 415:
>>
>>> 413: private static native boolean isCDDrive(String root);
>>> 414:
>>> 415: private static long[] getCDDriveSpace(String root) throws
>>> IOException {
>>
>> Why not pass
On Fri, 13 Dec 2024 21:10:31 GMT, Brian Burkhalter wrote:
> Perhaps the output of `df` is not being parsed correctly?
Actually I am getting
df: 'D:': No such file or directory
as the first line returned by the process that runs `df` when I run the test in
Cygwin. On the command line this does
On Fri, 13 Dec 2024 10:10:16 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
On Fri, 13 Dec 2024 10:10:22 GMT, Taizo Kurashige wrote:
>>> The native `GetXSpace` method needs to be defined on all platforms
>>
>> This change fixes that problem:
>>
>> --- a/test/jdk/java/io/File/libGetXSpace.c
>> +++ b/test/jdk/java/io/File/libGetXSpace.c
>> @@ -160,11 +160,11 @@ Java_GetX
On Wed, 11 Dec 2024 18:45:43 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/File/libGetXSpace.c line 165:
>>
>>> 163: #ifdef WINDOWS
>>> 164: JNIEXPORT jboolean JNICALL
>>> 165: Java_GetXSpace_isCDDrive
>>
>> The native `GetXSpace` method needs to be defined on all platforms,
>> otherwise we
On Thu, 12 Dec 2024 23:20:51 GMT, Brian Burkhalter wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add ifdef WINDOWS
>
> test/jdk/java/io/File/GetXSpace.java line 415:
>
>> 413: private static native boolea
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information
> about the size of the CD-ROM drive.
> Ge
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information
> about the size of the CD-ROM drive.
> Ge
On Mon, 9 Dec 2024 10:55:13 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW can
On Wed, 11 Dec 2024 18:40:41 GMT, Brian Burkhalter wrote:
> The native `GetXSpace` method needs to be defined on all platforms
This change fixes that problem:
--- a/test/jdk/java/io/File/libGetXSpace.c
+++ b/test/jdk/java/io/File/libGetXSpace.c
@@ -160,11 +160,11 @@ Java_GetXSpace_getSpace0
On Mon, 9 Dec 2024 10:55:13 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW can
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information
> about the size of the CD-ROM drive.
> Ge
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information
> about the size of the CD-ROM drive.
> Ge
On Fri, 6 Dec 2024 04:41:19 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW can
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information
> about the size of the CD-ROM drive.
> Ge
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information
> about the size of the CD-ROM drive.
> Ge
On Wed, 4 Dec 2024 01:28:36 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW can
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information
> about the size of the CD-ROM drive.
> Ge
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't g
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't g
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't g
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> For this reason, I use Cygwin's `df`.
Note that the proposed version, while it _does_ work in Cygwin, does **not**
work in WSL 1.
-
PR Comment: https://git.openjdk.org/jdk/pull/21799#issuecomment-2505054032
On Thu, 28 Nov 2024 00:03:32 GMT, Brian Burkhalter wrote:
> If there were also a simpler way to handle the empty drive case, that would
> be good.
Actually this simple patch appears to fix the problem with a CD drive attached
whether it is empty or contains a CD:
--- a/test/jdk/java/io/File/G
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't g
On Wed, 27 Nov 2024 04:28:23 GMT, Taizo Kurashige wrote:
>> It's in my queue to review this and test it on actual hardware.
>
> @bplb
>
> Sorry to bother you, but how is the review going? I would appreciate your
> response.
@kurashige23 Sorry, I've been tied up with other things. I will try to
On Fri, 1 Nov 2024 16:13:57 GMT, Brian Burkhalter wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't g
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't g
41 matches
Mail list logo
