Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v9]

2024-09-13 Thread Brett Okken
On Wed, 11 Sep 2024 13:15:57 GMT, Per Minborg wrote: >> src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java >> line 244: >> >>> 242: return (Architecture.isLittleEndian() >>> 243: ? Long.numberOfTrailingZeros(x) >>> 244: : Long.num

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v13]

2024-09-12 Thread Maurizio Cimadamore
On Thu, 12 Sep 2024 13:06:47 GMT, Per Minborg wrote: >> This PR proposes to improve the performance of `MemorySegment::mismatch` by >> using Java code rather than transitioning to native code. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v13]

2024-09-12 Thread Per Minborg
> This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Revert unrolling changes - Changes

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v12]

2024-09-12 Thread Per Minborg
On Thu, 12 Sep 2024 11:34:44 GMT, Maurizio Cimadamore wrote: >> In other words, I don't think the goal of this (and related) PR is "improve >> mismatch so that it blows other alternatives - like Unsafe, or array" out of >> the water - as much as it is "make sure that using MemorySegment::misma

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v12]

2024-09-12 Thread Maurizio Cimadamore
On Thu, 12 Sep 2024 10:54:47 GMT, Per Minborg wrote: >> This PR proposes to improve the performance of `MemorySegment::mismatch` by >> using Java code rather than transitioning to native code. > > Per Minborg has updated the pull request incrementally with two additional > commits since the las

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v12]

2024-09-12 Thread Maurizio Cimadamore
On Thu, 12 Sep 2024 11:32:22 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java >> line 204: >> >>> 202: // This gives about 20% performance increase for large values >>> of `length`. >>> 203: // On non-Aarch64 archit

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v12]

2024-09-12 Thread Maurizio Cimadamore
On Thu, 12 Sep 2024 11:30:12 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix yet another typo >> - Fix typo > > src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v12]

2024-09-12 Thread Per Minborg
On Thu, 12 Sep 2024 10:54:47 GMT, Per Minborg wrote: >> This PR proposes to improve the performance of `MemorySegment::mismatch` by >> using Java code rather than transitioning to native code. > > Per Minborg has updated the pull request incrementally with two additional > commits since the las

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v12]

2024-09-12 Thread Per Minborg
> This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. Per Minborg has updated the pull request incrementally with two additional commits since the last revision: - Fix yet another typo - Fix typo

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v10]

2024-09-12 Thread Per Minborg
On Fri, 6 Sep 2024 11:52:35 GMT, Per Minborg wrote: >> This PR proposes to improve the performance of `MemorySegment::mismatch` by >> using Java code rather than transitioning to native code. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v11]

2024-09-12 Thread Per Minborg
> This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v9]

2024-09-11 Thread Per Minborg
On Thu, 5 Sep 2024 17:58:11 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix errors in a benchmark > > src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java > line

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v9]

2024-09-11 Thread Per Minborg
On Fri, 6 Sep 2024 15:11:19 GMT, Brett Okken wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix errors in a benchmark > > src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java > line 244: >

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v9]

2024-09-11 Thread Per Minborg
On Thu, 5 Sep 2024 17:51:35 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix errors in a benchmark > > src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java > line

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v9]

2024-09-06 Thread Brett Okken
On Thu, 5 Sep 2024 17:47:16 GMT, Per Minborg wrote: >> This PR proposes to improve the performance of `MemorySegment::mismatch` by >> using Java code rather than transitioning to native code. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v9]

2024-09-06 Thread Maurizio Cimadamore
On Thu, 5 Sep 2024 17:50:04 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix errors in a benchmark > > src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java > line

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v10]

2024-09-06 Thread Per Minborg
> This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Use unaligned ops and rename benchmarks ---

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v9]

2024-09-05 Thread Maurizio Cimadamore
On Thu, 5 Sep 2024 18:02:32 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix errors in a benchmark > > src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java > line

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v9]

2024-09-05 Thread Maurizio Cimadamore
On Thu, 5 Sep 2024 17:47:16 GMT, Per Minborg wrote: >> This PR proposes to improve the performance of `MemorySegment::mismatch` by >> using Java code rather than transitioning to native code. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v9]

2024-09-05 Thread Maurizio Cimadamore
On Thu, 5 Sep 2024 17:47:16 GMT, Per Minborg wrote: >> This PR proposes to improve the performance of `MemorySegment::mismatch` by >> using Java code rather than transitioning to native code. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v9]

2024-09-05 Thread Maurizio Cimadamore
On Thu, 5 Sep 2024 17:47:16 GMT, Per Minborg wrote: >> This PR proposes to improve the performance of `MemorySegment::mismatch` by >> using Java code rather than transitioning to native code. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v9]

2024-09-05 Thread Maurizio Cimadamore
On Thu, 5 Sep 2024 17:47:16 GMT, Per Minborg wrote: >> This PR proposes to improve the performance of `MemorySegment::mismatch` by >> using Java code rather than transitioning to native code. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v9]

2024-09-05 Thread Per Minborg
> This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Fix errors in a benchmark - Change

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v8]

2024-09-05 Thread Maurizio Cimadamore
On Thu, 5 Sep 2024 17:21:32 GMT, Per Minborg wrote: >> This PR proposes to improve the performance of `MemorySegment::mismatch` by >> using Java code rather than transitioning to native code. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v8]

2024-09-05 Thread Per Minborg
> This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Lower the mismatch threshold - Cha

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v7]

2024-09-05 Thread Per Minborg
> This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v6]

2024-09-05 Thread Per Minborg
On Wed, 4 Sep 2024 10:14:30 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Consolidate logic in one method > > src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v6]

2024-09-05 Thread Per Minborg
> This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Consolidate logic in one method -

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v5]

2024-09-05 Thread Per Minborg
> This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Update benchmarks - Changes: - a

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v3]

2024-09-05 Thread Per Minborg
On Thu, 5 Sep 2024 11:15:22 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 10 additional >> com

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v4]

2024-09-05 Thread Per Minborg
> This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Add optimized checking - Changes:

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v3]

2024-09-05 Thread Maurizio Cimadamore
On Thu, 5 Sep 2024 08:34:11 GMT, Per Minborg wrote: >> This PR proposes to improve the performance of `MemorySegment::mismatch` by >> using Java code rather than transitioning to native code. > > Per Minborg has updated the pull request with a new target base due to a > merge or a rebase. The i

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v3]

2024-09-05 Thread Per Minborg
> This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch [v2]

2024-09-05 Thread Per Minborg
> This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Update src/java.base/share/classes/jdk/internal

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch

2024-09-04 Thread Chen Liang
On Wed, 4 Sep 2024 09:09:32 GMT, Per Minborg wrote: > This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java line 49: > 47: > 48: /

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch

2024-09-04 Thread Maurizio Cimadamore
On Wed, 4 Sep 2024 09:09:32 GMT, Per Minborg wrote: > This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java line 103: > 101: }

Re: RFR: 8339531: Improve performance of MemorySegment::mismatch

2024-09-04 Thread Maurizio Cimadamore
On Wed, 4 Sep 2024 09:09:32 GMT, Per Minborg wrote: > This PR proposes to improve the performance of `MemorySegment::mismatch` by > using Java code rather than transitioning to native code. src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java line 123: > 121: // Thi