On Thu, 5 Sep 2024 17:50:04 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix errors in a benchmark > > src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java > line 179: > >> 177: return 0; >> 178: } >> 179: i = >> AbstractMemorySegmentImpl.vectorizedMismatchLargeForBytes(src.sessionImpl(), >> dst.sessionImpl(), > > We should probably move `vectorizedMismatchLargeForBytes` in this class too, > for clarity I see the method is still in `AbstractMemorySegmentImpl`. Note that if we could move it here, we can then drop (I think) `SCOPED_MEMORY_ACCESS` from `AbstractMemorySegmentImpl`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20848#discussion_r1747218277
