Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v5]

2024-09-05 Thread Emanuel Peter
On Thu, 5 Sep 2024 07:42:26 GMT, Jatin Bhateja wrote: >> src/hotspot/share/opto/vectornode.hpp line 634: >> >>> 632: virtual int Opcode() const; >>> 633: }; >>> 634: >> >> This could also be a separate PR. Or are they somehow inseparable from the >> "saturation" changes? > > Not applicable

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v5]

2024-09-05 Thread Jatin Bhateja
On Tue, 3 Sep 2024 22:18:20 GMT, Sandhya Viswanathan wrote: >> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments resolved > > src/hotspot/cpu/x86/x86.ad line 10684: > >> 10682: match(Set dst (SaturatingSub

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v5]

2024-09-05 Thread Jatin Bhateja
On Tue, 3 Sep 2024 13:09:13 GMT, Emanuel Peter wrote: > You did in fact add `java/lang` methods. I think you need to add tests for > all of those. As well. That's going to be even more code to review. Hi @eme64 , As Paul suggested in offline mail chain, lets restrict the changes with this patc

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v5]

2024-09-04 Thread Emanuel Peter
On Tue, 3 Sep 2024 16:23:56 GMT, Sandhya Viswanathan wrote: >> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments resolved > > src/hotspot/cpu/x86/assembler_x86.cpp line 8470: > >> 8468: void Assembler::vpmax

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v5]

2024-09-03 Thread Sandhya Viswanathan
On Mon, 2 Sep 2024 12:20:59 GMT, Jatin Bhateja wrote: >> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> following new vector operators. >> >> >> . SUADD : Saturating unsigned addition. >> . SADD: Saturating signed addition. >>

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v5]

2024-09-03 Thread Sandhya Viswanathan
On Mon, 2 Sep 2024 12:20:59 GMT, Jatin Bhateja wrote: >> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> following new vector operators. >> >> >> . SUADD : Saturating unsigned addition. >> . SADD: Saturating signed addition. >>

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v5]

2024-09-03 Thread Emanuel Peter
On Mon, 2 Sep 2024 12:20:59 GMT, Jatin Bhateja wrote: >> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> following new vector operators. >> >> >> . SUADD : Saturating unsigned addition. >> . SADD: Saturating signed addition. >>

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v5]

2024-09-03 Thread Emanuel Peter
On Mon, 2 Sep 2024 12:20:59 GMT, Jatin Bhateja wrote: >> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> following new vector operators. >> >> >> . SUADD : Saturating unsigned addition. >> . SADD: Saturating signed addition. >>

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v5]

2024-09-03 Thread Emanuel Peter
On Mon, 2 Sep 2024 12:20:59 GMT, Jatin Bhateja wrote: >> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> following new vector operators. >> >> >> . SUADD : Saturating unsigned addition. >> . SADD: Saturating signed addition. >>

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v5]

2024-09-02 Thread Jatin Bhateja
> Hi All, > > As per the discussion on panama-dev mailing list[1], patch adds the support > following new vector operators. > > > . SUADD : Saturating unsigned addition. > . SADD: Saturating signed addition. > . SUSUB : Saturating unsigned subtraction. > . SSUB: