Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v2]

2024-09-03 Thread Sandhya Viswanathan
On Mon, 2 Sep 2024 12:15:10 GMT, Jatin Bhateja wrote: >> If the aim is to reduce the number of nodes, we could merge the >> Op_SaturatingAddVB, Op_SaturatingAddVS, Op_SaturatingAddVI, and >> Op_SaturatingAddVL into one Op_SaturatingAddV. Likewise for unsigned >> saturating add into Op_Saturati

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v2]

2024-09-02 Thread Jatin Bhateja
On Wed, 28 Aug 2024 16:05:45 GMT, Sandhya Viswanathan wrote: >> Wonder if it would have been simpler if we added unsigned vector operators >> like Op_SaturatingUnsignedAddVB etc. We are not adding unsigned data types >> to Java, only supporting unsigned (saturating) operations on existing sign

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v2]

2024-08-28 Thread Sandhya Viswanathan
On Wed, 28 Aug 2024 00:12:26 GMT, Sandhya Viswanathan wrote: >> Hey @jaskarth , Central idea behind introducing VectorReinterpretNode after >> unsigned vector IR is to facilitate unboxing-boxing optimization, this >> explicit reinterpretation ensures type compatibility between value being >>

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v2]

2024-08-27 Thread Sandhya Viswanathan
On Thu, 15 Aug 2024 06:59:53 GMT, Jatin Bhateja wrote: >>> its usage in existing patch is limited to [type >>> comparison.](https://github.com/openjdk/jdk/pull/20507/files#diff-3559dcf23b719805be5fd06fd5c1851dbd8f53e47afe6d99cba13a3de0ebc6b2R1542) >> >> Ah, that makes sense to me. I took a clos

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v2]

2024-08-15 Thread Jatin Bhateja
On Thu, 15 Aug 2024 03:01:00 GMT, Jasmine Karthikeyan wrote: >> @jaskarth , its usage in existing patch is limited to [type >> comparison.](https://github.com/openjdk/jdk/pull/20507/files#diff-3559dcf23b719805be5fd06fd5c1851dbd8f53e47afe6d99cba13a3de0ebc6b2R1542). >> >> >> My plan is to addr

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v2]

2024-08-14 Thread Jasmine Karthikeyan
On Mon, 12 Aug 2024 06:29:03 GMT, Jatin Bhateja wrote: > its usage in existing patch is limited to [type > comparison.](https://github.com/openjdk/jdk/pull/20507/files#diff-3559dcf23b719805be5fd06fd5c1851dbd8f53e47afe6d99cba13a3de0ebc6b2R1542) Ah, that makes sense to me. I took a closer look an

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v2]

2024-08-12 Thread Paul Sandoz
On Thu, 8 Aug 2024 17:20:06 GMT, Jatin Bhateja wrote: >> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> following new vector operators. >> >> >> . SATURATING_UADD : Saturating unsigned addition. >> . SATURATING_ADD: Saturating sig

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v2]

2024-08-11 Thread Jatin Bhateja
On Fri, 9 Aug 2024 03:28:53 GMT, Jasmine Karthikeyan wrote: >> Jatin Bhateja has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v2]

2024-08-08 Thread Jasmine Karthikeyan
On Thu, 8 Aug 2024 17:20:06 GMT, Jatin Bhateja wrote: >> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> following new vector operators. >> >> >> . SATURATING_UADD : Saturating unsigned addition. >> . SATURATING_ADD: Saturating sig

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v2]

2024-08-08 Thread Jatin Bhateja
> Hi All, > > As per the discussion on panama-dev mailing list[1], patch adds the support > following new vector operators. > > > . SATURATING_UADD : Saturating unsigned addition. > . SATURATING_ADD: Saturating signed addition. > . SATURATING_USUB : Saturating unsigned