On Fri, 21 Jun 2024 01:58:05 GMT, Naoto Sato wrote:
> Out of curiosity, what's the rationale behind the currency name change from
> "Zimbabwe Dollar" (ISO 4217 definition) to "Zimbabwean Dollar"?
I'm not sure.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19813#discussion_
On Thu, 20 Jun 2024 20:12:39 GMT, Justin Lu wrote:
>> Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
>>
>> Specifically, the introduction of the new currency, Zimbabwe Gold.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since
On Thu, 20 Jun 2024 20:30:36 GMT, Steven Loomis wrote:
> CLDR is aware of this change but hasn't added it yet. We're mid cycle so it
> won't be much more than metadata this round due to timing.
> https://unicode-org.atlassian.net/issues/CLDR-17751 if you want to track.
Out of curiosity, what's
On Thu, 20 Jun 2024 19:47:56 GMT, Naoto Sato wrote:
>> I see your point. CLDR takes precedence over ISO4217 regarding currencies
>> here?
>
> That is more consistent IMO
CLDR is aware of this change but hasn't added it yet. We're mid cycle so it
won't be much more than metadata this round due
On Thu, 20 Jun 2024 19:51:51 GMT, Naoto Sato wrote:
> The point I wanted to make is that the text file only contains the "list one"
> part of the ISO 4217.
Renamed the file name to "ISO4217-list-one.txt"
-
PR Comment: https://git.openjdk.org/jdk/pull/19813#issuecomment-2181478826
> Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
>
> Specifically, the introduction of the new currency, Zimbabwe Gold.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
reflect review: change txt name
--
On Thu, 20 Jun 2024 19:01:29 GMT, Justin Lu wrote:
> > It's not about this update, but it may be better to rename the
> > `tablea1.txt` data file to `list-one.txt` or something along the line. The
> > name `tablea1` is obsolete, and it is now called "List one: Currency, fund
> > and precious m
On Thu, 20 Jun 2024 19:01:26 GMT, Justin Lu wrote:
>> src/java.base/share/classes/sun/util/resources/CurrencyNames.properties line
>> 516:
>>
>>> 514: zmk=Zambian Kwacha
>>> 515: zwd=Zimbabwean Dollar (1980-2008)
>>> 516: zwg=Zimbabwe Gold
>>
>> It's interesting to see the difference `Zimbabwe
On Thu, 20 Jun 2024 18:21:41 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect review comments
>
> src/java.base/share/classes/sun/util/resources/CurrencyNames.properties line
> 516:
>
>> 514:
> Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
>
> Specifically, the introduction of the new currency, Zimbabwe Gold.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
reflect review comments
-
On Thu, 20 Jun 2024 18:36:22 GMT, Naoto Sato wrote:
> It's not about this update, but it may be better to rename the `tablea1.txt`
> data file to `list-one.txt` or something along the line. The name `tablea1`
> is obsolete, and it is now called "List one: Currency, fund and precious
> metal co
On Thu, 20 Jun 2024 18:01:39 GMT, Justin Lu wrote:
> Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
>
> Specifically, the introduction of the new currency, Zimbabwe Gold.
It's not about this update, but it may be better to rename the `tablea1.txt`
data file to `lis
On Thu, 20 Jun 2024 18:01:39 GMT, Justin Lu wrote:
> Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
>
> Specifically, the introduction of the new currency, Zimbabwe Gold.
src/java.base/share/classes/sun/util/resources/CurrencyNames.properties line
516:
> 514: zmk=
13 matches
Mail list logo
