On Thu, 20 Jun 2024 18:01:39 GMT, Justin Lu <j...@openjdk.org> wrote:
> Please review this PR which incorporates the ISO 4217 Amendment 177 Update. > > Specifically, the introduction of the new currency, Zimbabwe Gold. src/java.base/share/classes/sun/util/resources/CurrencyNames.properties line 516: > 514: zmk=Zambian Kwacha > 515: zwd=Zimbabwean Dollar (1980-2008) > 516: zwg=Zimbabwe Gold It's interesting to see the difference `Zimbabwe` and `Zimbabwean` here. The latter is from CLDR and the name for ZWG is not yet available, so we may need to pull the name from CLDR later. src/java.base/share/data/currency/CurrencyData.properties line 585: > 583: ZM=ZMW > 584: # ZIMBABWE > 585: ZW=ZWL;2024-08-31-22-00-00;ZWG JDK switches the currency at the beginning of the transition period. So in this case, it's 6/25. So we don't need to even specify the transition at all, as the next build drop is beyond that date. test/jdk/java/util/Currency/tablea1.txt line 279: > 277: YE YER 886 2 > 278: ZM ZMW 967 2 > 279: ZW ZWL 932 2 2024-08-31-22-00-00 ZWG 924 > 2 Same as above ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19813#discussion_r1647972810 PR Review Comment: https://git.openjdk.org/jdk/pull/19813#discussion_r1647967701 PR Review Comment: https://git.openjdk.org/jdk/pull/19813#discussion_r1647967861
