Re: RFR: 8320919: Clarify Locale related system properties [v8]

2023-12-18 Thread Naoto Sato
> This is a doc change to clarify what the `Default Locale` is, and how it is > established during the system startup using the system properties. Those > locale-related system properties have existed since the early days of Java, > but have never been publicly documented before. It is also the

Re: RFR: 8320919: Clarify Locale related system properties [v7]

2023-12-15 Thread Naoto Sato
> This is a doc change to clarify what the `Default Locale` is, and how it is > established during the system startup using the system properties. Those > locale-related system properties have existed since the early days of Java, > but have never been publicly documented before. It is also the

Re: RFR: 8320919: Clarify Locale related system properties [v6]

2023-12-15 Thread Naoto Sato
On Fri, 15 Dec 2023 20:39:47 GMT, Brent Christian wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects review comments > > src/java.base/share/classes/java/util/Locale.java line 327: > >> 325: * the value of th

Re: RFR: 8320919: Clarify Locale related system properties [v6]

2023-12-15 Thread Brent Christian
On Thu, 14 Dec 2023 21:50:01 GMT, Naoto Sato wrote: >> This is a doc change to clarify what the `Default Locale` is, and how it is >> established during the system startup using the system properties. Those >> locale-related system properties have existed since the early days of Java, >> but h

Re: RFR: 8320919: Clarify Locale related system properties [v5]

2023-12-14 Thread Naoto Sato
On Thu, 14 Dec 2023 21:27:06 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects review comments > > src/java.base/share/classes/java/util/Locale.java line 264: > >> 262: * Default Locale >> 2

Re: RFR: 8320919: Clarify Locale related system properties [v6]

2023-12-14 Thread Naoto Sato
> This is a doc change to clarify what the `Default Locale` is, and how it is > established during the system startup using the system properties. Those > locale-related system properties have existed since the early days of Java, > but have never been publicly documented before. It is also the

Re: RFR: 8320919: Clarify Locale related system properties [v5]

2023-12-14 Thread Roger Riggs
On Wed, 13 Dec 2023 19:00:52 GMT, Naoto Sato wrote: >> This is a doc change to clarify what the `Default Locale` is, and how it is >> established during the system startup using the system properties. Those >> locale-related system properties have existed since the early days of Java, >> but h

Re: RFR: 8320919: Clarify Locale related system properties [v5]

2023-12-13 Thread Naoto Sato
On Wed, 13 Dec 2023 21:25:13 GMT, Jorn Vernee wrote: >> Right, I suggested putting that in parentheses. Historically we haven't been >> very formal about distinguishing between normative (Java SE) specifications >> and informative text that talks about implementations. In this case I felt >> t

Re: RFR: 8320919: Clarify Locale related system properties [v5]

2023-12-13 Thread Jorn Vernee
On Wed, 13 Dec 2023 05:19:25 GMT, Stuart Marks wrote: >> The `-D` command-line option is not a part of the Java SE specification but >> an allowed behavior, so it may not be a normative description here. > > Right, I suggested putting that in parentheses. Historically we haven't been > very for

Re: RFR: 8320919: Clarify Locale related system properties [v5]

2023-12-13 Thread Naoto Sato
> This is a doc change to clarify what the `Default Locale` is, and how it is > established during the system startup using the system properties. Those > locale-related system properties have existed since the early days of Java, > but have never been publicly documented before. It is also the

Re: RFR: 8320919: Clarify Locale related system properties [v4]

2023-12-13 Thread Naoto Sato
On Wed, 13 Dec 2023 18:33:13 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects review comments > > src/java.base/share/classes/java/util/Locale.java line 317: > >> 315: * If the default Loca

Re: RFR: 8320919: Clarify Locale related system properties [v4]

2023-12-13 Thread Roger Riggs
On Wed, 13 Dec 2023 18:01:55 GMT, Naoto Sato wrote: >> This is a doc change to clarify what the `Default Locale` is, and how it is >> established during the system startup using the system properties. Those >> locale-related system properties have existed since the early days of Java, >> but h

Re: RFR: 8320919: Clarify Locale related system properties [v3]

2023-12-13 Thread Naoto Sato
On Mon, 11 Dec 2023 23:20:25 GMT, Naoto Sato wrote: >> This is a doc change to clarify what the `Default Locale` is, and how it is >> established during the system startup using the system properties. Those >> locale-related system properties have existed since the early days of Java, >> but h

Re: RFR: 8320919: Clarify Locale related system properties [v4]

2023-12-13 Thread Naoto Sato
> This is a doc change to clarify what the `Default Locale` is, and how it is > established during the system startup using the system properties. Those > locale-related system properties have existed since the early days of Java, > but have never been publicly documented before. It is also the

Re: RFR: 8320919: Clarify Locale related system properties [v3]

2023-12-12 Thread Stuart Marks
On Mon, 11 Dec 2023 23:20:25 GMT, Naoto Sato wrote: >> This is a doc change to clarify what the `Default Locale` is, and how it is >> established during the system startup using the system properties. Those >> locale-related system properties have existed since the early days of Java, >> but h

Re: RFR: 8320919: Clarify Locale related system properties [v3]

2023-12-12 Thread Stuart Marks
On Mon, 11 Dec 2023 23:17:01 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/util/Locale.java line 301: >> >>> 299: * is unparsable, it is ignored. The overriding values of other >>> properties are not >>> 300: * checked for syntax or validity and are used directly in the default

Re: RFR: 8320919: Clarify Locale related system properties [v3]

2023-12-11 Thread Naoto Sato
> This is a doc change to clarify what the `Default Locale` is, and how it is > established during the system startup using the system properties. Those > locale-related system properties have existed since the early days of Java, > but have never been publicly documented before. It is also the

Re: RFR: 8320919: Clarify Locale related system properties [v3]

2023-12-11 Thread Naoto Sato
On Mon, 11 Dec 2023 22:42:56 GMT, Justin Lu wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments > > src/java.base/share/classes/java/util/Locale.java line 270: > >> 268: * >> 269: * The locale-related

Re: RFR: 8320919: Clarify Locale related system properties [v2]

2023-12-11 Thread Naoto Sato
> This is a doc change to clarify what the `Default Locale` is, and how it is > established during the system startup using the system properties. Those > locale-related system properties have existed since the early days of Java, > but have never been publicly documented before. It is also the

Re: RFR: 8320919: Clarify Locale related system properties

2023-12-11 Thread Justin Lu
On Mon, 11 Dec 2023 18:54:25 GMT, Naoto Sato wrote: > This is a doc change to clarify what the `Default Locale` is, and how it is > established during the system startup using the system properties. Those > locale-related system properties have existed since the early days of Java, > but have