On Wed, 13 Dec 2023 18:01:55 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> This is a doc change to clarify what the `Default Locale` is, and how it is
>> established during the system startup using the system properties. Those
>> locale-related system properties have existed since the early days of Java,
>> but have never been publicly documented before. It is also the intention of
>> this PR to clarify those system properties and how they are overridden. A
>> corresponding CSR has been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflects review comments
Marked as reviewed by rriggs (Reviewer).
src/java.base/share/classes/java/util/Locale.java line 305:
> 303: * results in a default Locale with no extensions, while specifying
> 304: * {@code -Duser.language=foobarbaz} results in a default Locale whose
> language is
> 305: * "foobarbaz".)
The parenthesized sentence is so long that its not effective in making it seem
like an option.
The "Typical," is sufficient to indicate it is not part of the spec. Drop the
parens.
src/java.base/share/classes/java/util/Locale.java line 317:
> 315: * If the default Locale is changed with {@link #setDefault(Locale)},
> the corresponding
> 316: * system properties are not altered. It is not recommended that
> applications read
> 317: * these system properties and parse/interpret them as their values may
> be out of date.
"parse/interpret" -> "parse or interpret".
-------------
PR Review: https://git.openjdk.org/jdk/pull/17065#pullrequestreview-1780257611
PR Review Comment: https://git.openjdk.org/jdk/pull/17065#discussion_r1425741255
PR Review Comment: https://git.openjdk.org/jdk/pull/17065#discussion_r1425740095
