On Mon, 28 Oct 2024 16:16:14 GMT, Calvin Cheung wrote:
>> Summary of changes:
>>
>> Before dumping info the archive, all the module names from `--add-modules`
>> will be sorted and then concatenated into one string with comma as the
>> separator between module names.
>>
>> During runtime, sam
On Mon, 28 Oct 2024 16:16:14 GMT, Calvin Cheung wrote:
>> Summary of changes:
>>
>> Before dumping info the archive, all the module names from `--add-modules`
>> will be sorted and then concatenated into one string with comma as the
>> separator between module names.
>>
>> During runtime, sam
On Mon, 28 Oct 2024 16:16:14 GMT, Calvin Cheung wrote:
>> Summary of changes:
>>
>> Before dumping info the archive, all the module names from `--add-modules`
>> will be sorted and then concatenated into one string with comma as the
>> separator between module names.
>>
>> During runtime, sam
On Mon, 28 Oct 2024 09:09:35 GMT, Alan Bateman wrote:
>> Thanks, I'll get back to you on but I want see how this will behave with
>> ALL-MODULE-PATH as that will sometimes appear in Maven environments.
>
> I chatted with Calvin about this change. Testing that the root modules
> specified to --a
> Summary of changes:
>
> Before dumping info the archive, all the module names from `--add-modules`
> will be sorted and then concatenated into one string with comma as the
> separator between module names.
>
> During runtime, same function will be used to obtain the string in the same
> form
On Tue, 22 Oct 2024 12:42:30 GMT, Alan Bateman wrote:
>> I've removed the `if` check at the beginning of the method.
>
> Thanks, I'll get back to you on but I want see how this will behave with
> ALL-MODULE-PATH as that will sometimes appear in Maven environments.
I chatted with Calvin about th
On Mon, 21 Oct 2024 16:29:40 GMT, Calvin Cheung wrote:
>> Good point as ALL-SYSTEM and ALL-MODULE-PATH are allowed in the value. I
>> assume you don't need to special case the single value case as this is dump
>> time so not performance critical.
>
> I've removed the `if` check at the beginning
On Mon, 21 Oct 2024 13:17:10 GMT, Alan Bateman wrote:
>> Hi Alan,
>> I tried your suggestion but it can't handle the `ALL-SYSTEM` case.
>> I made some slight adjustments to your patch as follows:
>>
>>
>> /**
>> * Returns true if all modules named in the given set are in the
>> Config
> Summary of changes:
>
> Before dumping info the archive, all the module names from `--add-modules`
> will be sorted and then concatenated into one string with comma as the
> separator between module names.
>
> During runtime, same function will be used to obtain the string in the same
> form
On Mon, 21 Oct 2024 05:15:50 GMT, Calvin Cheung wrote:
>> src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java line
>> 467:
>>
>>> 465: if (CDS.isDumpingStaticArchive()
>>> 466: && !haveUpgradeModulePath
>>> 467: && (addModules.isEmpty() |
On Fri, 18 Oct 2024 11:26:30 GMT, Alan Bateman wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @rose00 comment
>
> src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java line 467:
>
>> 465:
On Thu, 17 Oct 2024 01:28:41 GMT, Calvin Cheung wrote:
>> Summary of changes:
>>
>> Before dumping info the archive, all the module names from `--add-modules`
>> will be sorted and then concatenated into one string with comma as the
>> separator between module names.
>>
>> During runtime, sam
On Wed, 16 Oct 2024 23:18:42 GMT, John R Rose wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @rose00 comment
>
> src/hotspot/share/classfile/modules.cpp line 697:
>
>> 695: st.print("%s%s", prefix, m);
>>
> Summary of changes:
>
> Before dumping info the archive, all the module names from `--add-modules`
> will be sorted and then concatenated into one string with comma as the
> separator between module names.
>
> During runtime, same function will be used to obtain the string in the same
> form
On Wed, 16 Oct 2024 22:46:40 GMT, Calvin Cheung wrote:
> Summary of changes:
>
> Before dumping info the archive, all the module names from `--add-modules`
> will be sorted and then concatenated into one string with comma as the
> separator between module names.
>
> During runtime, same funct
15 matches
Mail list logo
