On Mon, 28 Oct 2024 16:16:14 GMT, Calvin Cheung <cche...@openjdk.org> wrote:
>> Summary of changes: >> >> Before dumping info the archive, all the module names from `--add-modules` >> will be sorted and then concatenated into one string with comma as the >> separator between module names. >> >> During runtime, same function will be used to obtain the string in the same >> format with sorted module names. The string will be compared with the one >> from the archive to determine if the same module names were specified during >> dump time. >> >> ModuleBootstrap.java >> The `addModulesFromRuntimeImage` method is added to check if the >> modules in `addModules` are from the runtime image. If any of the modules >> isn't in the runtime image, archiving will be disabled. >> >> ArchivedModuleGraph.java >> The constructor has an addition argument `Set addModules` >> The `get` method also has an addition argument `Set addModules`. It >> returns the `archivedModuleGraph` only if both the `mainModule` and the >> `addModules` are the same as the input arguments. >> >> Passed tiers 1 - 4 testing. > > Calvin Cheung has updated the pull request incrementally with one additional > commit since the last revision: > > allow --add-modules add modules that aren't in the runtime image LGTM ------------- Marked as reviewed by iklam (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21553#pullrequestreview-2406843361
