Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v3]

2023-09-28 Thread Maurizio Cimadamore
On Thu, 28 Sep 2023 08:38:27 GMT, Aggelos Biboudis wrote: >> I agree. Also, this is not helped by the fact that in this particular >> message, the `_` does not appear in a variable declaration. Maybe we should >> use two distinct messages for when `_` is found as an "expression" (e.g. an >> i

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v3]

2023-09-28 Thread Maurizio Cimadamore
On Thu, 28 Sep 2023 08:40:20 GMT, Aggelos Biboudis wrote: >> This PR finalizes the feature of unnamed variables and patterns. >> >> - >> ### Progress >> - [ ] Change must be properly reviewed (1 review required, with at least 1 >> [Reviewer](https://openjdk.org/bylaws#reviewer)) >> - [

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v3]

2023-09-28 Thread Aggelos Biboudis
On Tue, 26 Sep 2023 10:21:06 GMT, Maurizio Cimadamore wrote: >> test/langtools/tools/javac/lambda/IdentifierTest9.out line 33: >> >>> 31: IdentifierTest.java:152:17: compiler.err.use.of.underscore.not.allowed >>> 32: IdentifierTest.java:158:16: >>> compiler.err.use.of.underscore.not.allowed.wi

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v3]

2023-09-28 Thread Aggelos Biboudis
> This PR finalizes the feature of unnamed variables and patterns. > > - > ### Progress > - [ ] Change must be properly reviewed (1 review required, with at least 1 > [Reviewer](https://openjdk.org/bylaws#reviewer)) > - [x] Change must not contain extraneous whitespace > - [x] Commit mess