On Thu, 28 Sep 2023 08:38:27 GMT, Aggelos Biboudis <abimpou...@openjdk.org> 
wrote:

>> I agree. Also, this is not helped by the fact that in this particular 
>> message, the `_` does not appear in a variable declaration. Maybe we should 
>> use two distinct messages for when `_` is found as an "expression" (e.g. an 
>> identifier) and when it is used as a declaration _name_.
>
> @mcimadamore @lahodaj I attempted to do this split for non variables that do 
> not allow underscore. I print the simple version of the error message. Is 
> that what you meant Maurizio?
> 
> I also fixed the `UnderscoreAsIdent` adding the missing `--release 9`. It was 
> the same omission as with other tests that @lahodaj pointed.

This looks much better!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15649#discussion_r1339840526

Reply via email to