On Tue, 17 Jan 2023 18:58:15 GMT, Ioi Lam wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> enable CDSHeapVerifier::verify() for non-debug build
>
> LGTM
Thanks @iklam and @dholmes-ora for the review.
On Tue, 17 Jan 2023 17:40:33 GMT, Calvin Cheung wrote:
>> Moving the `ArchivedEnumTest.java` from `runtime/cds/appcds/cacheObject` to
>> `jdk/internal/misc/CDS` so that the test will be run in jdk-tier1. This is
>> to avoid inadvertently breakage of the test like in JDK-8292499.
>>
>> Since jd
On Wed, 18 Jan 2023 02:19:04 GMT, David Holmes wrote:
> I'm a bit confused. The JBS issue lists two things to do to improve
> verification, but all this PR seems to do is move the test - in which case
> the JBS issue should be updated.
>
We will only address item [2] in the bug description in