On Tue, 17 Jan 2023 17:40:33 GMT, Calvin Cheung <cche...@openjdk.org> wrote:

>> Moving the `ArchivedEnumTest.java` from `runtime/cds/appcds/cacheObject` to 
>> `jdk/internal/misc/CDS` so that the test will be run in jdk-tier1. This is 
>> to avoid inadvertently breakage of the test like in JDK-8292499.
>> 
>> Since jdk tier testing runs with product builds, the 
>> CDSHeapVerifier::verify() needs to be enabled with product builds. 
>> Currently, the verify() function only checks built-in classes. 
>> 
>> Testing: jdk-tier1, tier3, tier4.
>
> Calvin Cheung has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   enable CDSHeapVerifier::verify() for non-debug build

Thanks for the updates to JBS and the PR regarding the change in verification 
behaviour.

Looks good.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11999

Reply via email to