Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly [v3]

2022-11-08 Thread Jaikiran Pai
On Tue, 8 Nov 2022 00:26:56 GMT, Aleksei Efimov wrote: >> ### The Proposed Change >> >> The proposed change updates JNDI's `DnsClient` internal implementation to >> use `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS). >> The main motivation behind this change is to make JNDI/D

Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly [v3]

2022-11-08 Thread Daniel Fuchs
On Tue, 8 Nov 2022 00:26:56 GMT, Aleksei Efimov wrote: >> ### The Proposed Change >> >> The proposed change updates JNDI's `DnsClient` internal implementation to >> use `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS). >> The main motivation behind this change is to make JNDI/D

Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly [v3]

2022-11-07 Thread Aleksei Efimov
> ### The Proposed Change > > The proposed change updates JNDI's `DnsClient` internal implementation to use > `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS). > The main motivation behind this change is to make JNDI/DNS lookups friendly > to virtual-thread environments and upda

Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly [v3]

2022-11-07 Thread Aleksei Efimov
On Mon, 7 Nov 2022 20:39:27 GMT, Daniel Fuchs wrote: >> Thanks for spotting that, Jai. >> You're correct that in its current version the fix changed an old logic of >> `doUdpQuery`/`query` methods: >> Before this change the method was returning `null` not when a receive is >> timed out but when

Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly [v2]

2022-11-07 Thread Aleksei Efimov
On Mon, 7 Nov 2022 20:26:54 GMT, Daniel Fuchs wrote: >> Aleksei Efimov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comments > > src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DNSDatagramChannelFactory.java > line 2

Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly [v2]

2022-11-07 Thread Daniel Fuchs
On Mon, 7 Nov 2022 15:39:55 GMT, Aleksei Efimov wrote: >> src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsClient.java line 470: >> >>> 468: } while (timeoutLeft > MIN_TIMEOUT); >>> 469: // no matching packet received within the timeout >>> 470:

Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly [v2]

2022-11-07 Thread Daniel Fuchs
On Mon, 7 Nov 2022 19:28:56 GMT, Aleksei Efimov wrote: >> ### The Proposed Change >> >> The proposed change updates JNDI's `DnsClient` internal implementation to >> use `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS). >> The main motivation behind this change is to make JNDI/D

Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly [v2]

2022-11-07 Thread Aleksei Efimov
> ### The Proposed Change > > The proposed change updates JNDI's `DnsClient` internal implementation to use > `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS). > The main motivation behind this change is to make JNDI/DNS lookups friendly > to virtual-thread environments and upda

Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly [v2]

2022-11-07 Thread Aleksei Efimov
On Mon, 7 Nov 2022 15:41:40 GMT, Aleksei Efimov wrote: >> src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsClient.java line 185: >> >>> 183: public void close() { >>> 184: try { >>> 185: udpChannelSelector.close(); >> >> Do you think we should now maintain a `closed`

Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly

2022-11-07 Thread Aleksei Efimov
On Mon, 7 Nov 2022 07:13:04 GMT, Jaikiran Pai wrote: >> ### The Proposed Change >> >> The proposed change updates JNDI's `DnsClient` internal implementation to >> use `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS). >> The main motivation behind this change is to make JNDI/DNS

Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly

2022-11-07 Thread Alan Bateman
On Sun, 6 Nov 2022 16:39:48 GMT, Aleksei Efimov wrote: > ### The Proposed Change > > The proposed change updates JNDI's `DnsClient` internal implementation to use > `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS). > The main motivation behind this change is to make JNDI/DNS lo

Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly

2022-11-06 Thread Jaikiran Pai
On Sun, 6 Nov 2022 16:39:48 GMT, Aleksei Efimov wrote: > ### The Proposed Change > > The proposed change updates JNDI's `DnsClient` internal implementation to use > `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS). > The main motivation behind this change is to make JNDI/DNS lo

Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly

2022-11-06 Thread Jaikiran Pai
On Sun, 6 Nov 2022 16:39:48 GMT, Aleksei Efimov wrote: > ### The Proposed Change > > The proposed change updates JNDI's `DnsClient` internal implementation to use > `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS). > The main motivation behind this change is to make JNDI/DNS lo

Re: RFR: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly

2022-11-06 Thread Jaikiran Pai
On Sun, 6 Nov 2022 16:39:48 GMT, Aleksei Efimov wrote: > ### The Proposed Change > > The proposed change updates JNDI's `DnsClient` internal implementation to use > `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS). > The main motivation behind this change is to make JNDI/DNS lo