Re: RFR: JDK-8315921: Invalid CSS declarations in java.lang class documentation [v2]

2023-11-02 Thread Hannes Wallnöfer
On Thu, 2 Nov 2023 10:57:15 GMT, Hannes Wallnöfer wrote: >> This change fixes two errors in inline HTML styles in the `java.lang` >> package: >> >> - wrong CSS property name in `java.lang.String` >> - CSS declaration terminated by colon instead of semicolon in >> `java.lang.Thread` >> >>

Re: RFR: JDK-8315921: Invalid CSS declarations in java.lang class documentation [v2]

2023-11-02 Thread Alan Bateman
On Thu, 2 Nov 2023 10:57:15 GMT, Hannes Wallnöfer wrote: >> This change fixes two errors in inline HTML styles in the `java.lang` >> package: >> >> - wrong CSS property name in `java.lang.String` >> - CSS declaration terminated by colon instead of semicolon in >> `java.lang.Thread` >> >>

Re: RFR: JDK-8315921: Invalid CSS declarations in java.lang class documentation [v2]

2023-11-02 Thread Hannes Wallnöfer
On Wed, 25 Oct 2023 09:09:07 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/java/lang/Thread.java line 192: >> >>> 190: * with the following system properties: >>> 191: * >>> 192: * System properties >> >> Just out of curiosity, is that semi-colon even needed, or would >> `display

Re: RFR: JDK-8315921: Invalid CSS declarations in java.lang class documentation [v2]

2023-11-02 Thread Hannes Wallnöfer
On Wed, 25 Oct 2023 09:04:37 GMT, Jaikiran Pai wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Find and fix more invalid CSS declarations > > Hello Hannes, the changes look fine to me. I wasn't aware we had cus

Re: RFR: JDK-8315921: Invalid CSS declarations in java.lang class documentation [v2]

2023-11-02 Thread Hannes Wallnöfer
> This change fixes two errors in inline HTML styles in the `java.lang` > package: > > - wrong CSS property name in `java.lang.String` > - CSS declaration terminated by colon instead of semicolon in > `java.lang.Thread` > > Both errors caused the style declarations to be ignored and an erro

Re: RFR: JDK-8315921: Invalid CSS declarations in java.lang class documentation

2023-10-25 Thread Jaikiran Pai
On Wed, 25 Oct 2023 09:05:11 GMT, Jaikiran Pai wrote: >> This change fixes two errors in inline HTML styles in the `java.lang` >> package: >> >> - wrong CSS property name in `java.lang.String` >> - CSS declaration terminated by colon instead of semicolon in >> `java.lang.Thread` >> >> Bot

Re: RFR: JDK-8315921: Invalid CSS declarations in java.lang class documentation

2023-10-25 Thread Jaikiran Pai
On Fri, 15 Sep 2023 13:56:21 GMT, Hannes Wallnöfer wrote: > This change fixes two errors in inline HTML styles in the `java.lang` > package: > > - wrong CSS property name in `java.lang.String` > - CSS declaration terminated by colon instead of semicolon in > `java.lang.Thread` > > Both er

RFR: JDK-8315921: Invalid CSS declarations in java.lang class documentation

2023-09-15 Thread Hannes Wallnöfer
This change fixes two errors in inline HTML styles in the `java.lang` package: - wrong CSS property name in `java.lang.String` - CSS declaration terminated by colon instead of semicolon in `java.lang.Thread` Both errors caused the style declarations to be ignored and an error message to be