On Fri, 15 Sep 2023 13:56:21 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
> This change fixes two errors in inline HTML styles in the `java.lang` > package: > > - wrong CSS property name in `java.lang.String` > - CSS declaration terminated by colon instead of semicolon in > `java.lang.Thread` > > Both errors caused the style declarations to be ignored and an error message > to be shown in the browser console. > > The bug is `noreg-doc`, I tested the docs in the browser to make sure the > error message is gone and the HTML displays as intended. Hello Hannes, the changes look fine to me. I wasn't aware we had custom CSS usage within javadoc tags in the JDK. src/java.base/share/classes/java/lang/Thread.java line 192: > 190: * with the following system properties: > 191: * <table class="striped"> > 192: * <caption style="display:none;">System properties</caption> Just out of curiosity, is that semi-colon even needed, or would `display:none` be enough? ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15762#pullrequestreview-1696767564 PR Review Comment: https://git.openjdk.org/jdk/pull/15762#discussion_r1371410008
