Re: RFR: JDK-8308350: Increase buffer size for jspawnhelper arguments [v2]

2023-05-18 Thread Thomas Stuefe
On Thu, 18 May 2023 13:46:54 GMT, Roger Riggs wrote: >> Thomas Stuefe has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits

Re: RFR: JDK-8308350: Increase buffer size for jspawnhelper arguments [v2]

2023-05-18 Thread Roger Riggs
On Thu, 18 May 2023 09:22:19 GMT, Thomas Stuefe wrote: >> Trivial fix for a small problem. >> >> jspawnhelper gets handed several file descriptors as arguments. The buffer >> size for this string is too small (7 chars per fd) to print out every >> conceivable int. This will overun the buffer i

Re: RFR: JDK-8308350: Increase buffer size for jspawnhelper arguments [v2]

2023-05-18 Thread Thomas Stuefe
> Trivial fix for a small problem. > > jspawnhelper gets handed several file descriptors as arguments. The buffer > size for this string is too small (7 chars per fd) to print out every > conceivable int. This will overun the buffer if we happen to have fds larger > than (printed size) 7 charac

Re: RFR: JDK-8308350: Increase buffer size for jspawnhelper arguments

2023-05-18 Thread Thomas Stuefe
On Thu, 18 May 2023 07:08:57 GMT, Thomas Stuefe wrote: > Trivial fix for a small problem. > > jspawnhelper gets handed several file descriptors as arguments. The buffer > size for this string is too small (7 chars per fd) to print out every > conceivable int. This will overun the buffer if we

RFR: JDK-8308350: Increase buffer size for jspawnhelper arguments

2023-05-18 Thread Thomas Stuefe
Trivial fix for a small problem. jspawnhelper gets handed several file descriptors as arguments. The buffer size for this string is too small (7 chars per fd) to print out every conceivable int. This will overun the buffer if we happen to have fds larger than (printed size) 7 characters. This c