Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes [v4]

2022-11-18 Thread Joe Darcy
> Update the spec of Class.getModifiers to match long-standing behavior for > primitive and array classes. Remove unneeded implementation flexibility with > regard to setting other bit positions. This work was prompted to better > support anticipated future Valhalla changes. > > Please also rev

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes [v3]

2022-11-18 Thread Joe Darcy
On Fri, 18 Nov 2022 19:40:40 GMT, Pavel Rappo wrote: > > Feeling stupid for asking this, but does it make any sense to keep the order > of modifiers "blessed" in text and tests? > > public protected private abstract static final transient volatile > synchronized native strictfp Will addre

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes [v3]

2022-11-18 Thread liach
On Fri, 18 Nov 2022 18:12:56 GMT, Joe Darcy wrote: >> Update the spec of Class.getModifiers to match long-standing behavior for >> primitive and array classes. Remove unneeded implementation flexibility with >> regard to setting other bit positions. This work was prompted to better >> support

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes [v3]

2022-11-18 Thread Pavel Rappo
On Fri, 18 Nov 2022 18:12:56 GMT, Joe Darcy wrote: >> Update the spec of Class.getModifiers to match long-standing behavior for >> primitive and array classes. Remove unneeded implementation flexibility with >> regard to setting other bit positions. This work was prompted to better >> support

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes [v3]

2022-11-18 Thread Dan Heidinga
On Fri, 18 Nov 2022 18:12:56 GMT, Joe Darcy wrote: >> Update the spec of Class.getModifiers to match long-standing behavior for >> primitive and array classes. Remove unneeded implementation flexibility with >> regard to setting other bit positions. This work was prompted to better >> support

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes [v3]

2022-11-18 Thread Mandy Chung
On Fri, 18 Nov 2022 18:12:56 GMT, Joe Darcy wrote: >> Update the spec of Class.getModifiers to match long-standing behavior for >> primitive and array classes. Remove unneeded implementation flexibility with >> regard to setting other bit positions. This work was prompted to better >> support

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes [v3]

2022-11-18 Thread Joe Darcy
> Update the spec of Class.getModifiers to match long-standing behavior for > primitive and array classes. Remove unneeded implementation flexibility with > regard to setting other bit positions. This work was prompted to better > support anticipated future Valhalla changes. > > Please also rev

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes [v2]

2022-11-18 Thread Joe Darcy
On Fri, 18 Nov 2022 17:42:41 GMT, Mandy Chung wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback. > > src/java.base/share/classes/java/lang/Class.java line 1311: > >> 1309: * void, its {@

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes [v2]

2022-11-18 Thread Mandy Chung
On Fri, 18 Nov 2022 17:46:33 GMT, Joe Darcy wrote: >> Update the spec of Class.getModifiers to match long-standing behavior for >> primitive and array classes. Remove unneeded implementation flexibility with >> regard to setting other bit positions. This work was prompted to better >> support

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes [v2]

2022-11-18 Thread Joe Darcy
> Update the spec of Class.getModifiers to match long-standing behavior for > primitive and array classes. Remove unneeded implementation flexibility with > regard to setting other bit positions. This work was prompted to better > support anticipated future Valhalla changes. > > Please also rev

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes

2022-11-18 Thread Joe Darcy
On Fri, 18 Nov 2022 15:04:13 GMT, Roger Riggs wrote: >> Update the spec of Class.getModifiers to match long-standing behavior for >> primitive and array classes. Remove unneeded implementation flexibility with >> regard to setting other bit positions. This work was prompted to better >> suppor

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes

2022-11-18 Thread Joe Darcy
On Fri, 18 Nov 2022 15:47:37 GMT, Dan Heidinga wrote: >> Update the spec of Class.getModifiers to match long-standing behavior for >> primitive and array classes. Remove unneeded implementation flexibility with >> regard to setting other bit positions. This work was prompted to better >> suppo

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes

2022-11-18 Thread Dan Heidinga
On Fri, 18 Nov 2022 03:26:38 GMT, Joe Darcy wrote: > Update the spec of Class.getModifiers to match long-standing behavior for > primitive and array classes. Remove unneeded implementation flexibility with > regard to setting other bit positions. This work was prompted to better > support anti

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes

2022-11-18 Thread Roger Riggs
On Fri, 18 Nov 2022 03:26:38 GMT, Joe Darcy wrote: > Update the spec of Class.getModifiers to match long-standing behavior for > primitive and array classes. Remove unneeded implementation flexibility with > regard to setting other bit positions. This work was prompted to better > support anti

RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes

2022-11-17 Thread Joe Darcy
Update the spec of Class.getModifiers to match long-standing behavior for primitive and array classes. Remove unneeded implementation flexibility with regard to setting other bit positions. This work was prompted to better support anticipated future Valhalla changes. Please also review the CSR: