On Fri, 18 Nov 2022 18:12:56 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> Update the spec of Class.getModifiers to match long-standing behavior for >> primitive and array classes. Remove unneeded implementation flexibility with >> regard to setting other bit positions. This work was prompted to better >> support anticipated future Valhalla changes. >> >> Please also review the CSR: https://bugs.openjdk.org/browse/JDK-8297237 > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Looks good. src/java.base/share/classes/java/lang/Class.java line 1346: > 1344: * If this {@code Class} object represents a primitive type or > 1345: * void, the flags are {@code PUBLIC}, {@code ABSTRACT}, and > 1346: * {@code FINAL}. Nit: extra space after `*` in L1344-1346. ------------- Marked as reviewed by mchung (Reviewer). PR: https://git.openjdk.org/jdk/pull/11229
