On Mon, 23 Jun 2025 23:09:13 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not co
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must
On Mon, 23 Jun 2025 17:18:13 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not co
On Mon, 23 Jun 2025 19:54:24 GMT, Roger Riggs wrote:
>> @RogerRiggs My preferred formatting style is like this:
>>
>>
>> default boolean setShardingKeyIfValid(ShardingKey shardingKey,
>> ShardingKey superShardingKey,
>>
On Mon, 23 Jun 2025 18:38:00 GMT, simon wrote:
>> src/java.sql/share/classes/java/sql/Connection.java line 1597:
>>
>>> 1595: default boolean setShardingKeyIfValid(ShardingKey shardingKey,
>>> 1596: ShardingKey
>>> superShardingKey,
>>> 1597:
On Mon, 23 Jun 2025 17:35:50 GMT, Roger Riggs wrote:
>> simon has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8360122: refactor code formatting to enforce 100 chars line length limit
>> for improved readability
>
> src/java.sql/share/cl
On Mon, 23 Jun 2025 17:18:13 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not co
On Mon, 23 Jun 2025 14:50:24 GMT, Roger Riggs wrote:
>> simon has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8360122: refactor code formatting to enforce 100 chars line length limit
>> for improved readability
>
> The indentation fixes
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must
On Mon, 23 Jun 2025 14:51:44 GMT, Chen Liang wrote:
> FYI people don't usually review on weekends (you opened this PR in a weekend)
> or holidays. This PR is sent to core-libs-dev list so people will eventually
> see and review it.
Great, @liach! Thanks for the information! 😄
-
P
On Mon, 23 Jun 2025 14:50:24 GMT, Roger Riggs wrote:
> The indentation fixes look ok. The reformatting of declarations seem
> unnecessary and create lines that are longer than desirable to be able to do
> side-by-side compares (100 char max). Generally, avoid just asking the IDE to
> re-format
On Sun, 22 Jun 2025 01:13:26 GMT, simon wrote:
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain e
On Sun, 22 Jun 2025 01:13:26 GMT, simon wrote:
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain e
On Sun, 22 Jun 2025 01:13:26 GMT, simon wrote:
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain e
8360122: Refine formatting of Connection.java interface
-
### Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1
[Reviewer](https://openjdk.org/bylaws#reviewer))
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issu
16 matches
Mail list logo
