On Fri, 17 Jan 2025 20:12:43 GMT, Daniel Jeliński wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8347740: Remove Windows version check and ignore IOException thrown by
>> File.createTempFile
>
> test/jdk/java
> Fix the means of determining whether an exception is to be expected in the
> Windows test.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8347740: Remove vestigial constant WINDOWS_11_MINIMUM_BUILD
-
Changes:
-
On Fri, 17 Jan 2025 20:00:16 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Remove W
On Fri, 17 Jan 2025 18:15:17 GMT, Brian Burkhalter wrote:
>> we don't care if there's an exception or not. It's not part of the spec.
>
> Yes, I think I'll rework this. Thanks.
The build number could be obtained from the value of the registry key
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows
N
> Fix the means of determining whether an exception is to be expected in the
> Windows test.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8347740: Remove Windows version check and ignore IOException thrown by
File.createTempF
On Fri, 17 Jan 2025 18:12:00 GMT, Daniel Jeliński wrote:
>>> I think it should accept both outcomes (success and the specific exception)
>>
>> But whether there's an exception varies by Windows version / build number.
>> I'll take another look and see whether there is some other way.
>
> we don
On Fri, 17 Jan 2025 17:09:51 GMT, Brian Burkhalter wrote:
>> No, it wouldn't cover any future Windows versions, but it would definitely
>> buy us a few years.
>>
>> Regarding a more permanent solution: the test is supposed to verify the fix
>> for [JDK-8013827](https://bugs.openjdk.org/browse/
On Fri, 17 Jan 2025 17:05:56 GMT, Daniel Jeliński wrote:
> I think it should accept both outcomes (success and the specific exception)
But whether there's an exception varies by Windows version / build number. I'll
take another look and see whether there is some other way.
-
PR Re
On Fri, 17 Jan 2025 16:46:58 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/File/createTempFile/SpecialTempFile.java line 95:
>>
>>> 93:
>>> 94: String cmd = "Systeminfo";
>>> 95: Process p = Runtime.getRuntime().exec(new String[] {cmd});
>>
>> I'm not a big fan of running th
On Fri, 17 Jan 2025 11:04:09 GMT, Daniel Jeliński wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8347740: Change Windows exceptionExpected to be based on build number
>
> test/jdk/java/io/File/createTempFile/S
On Wed, 15 Jan 2025 21:26:49 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Change W
On Thu, 16 Jan 2025 21:39:50 GMT, David Holmes wrote:
> Not sure it is worth all this effort, but that's a core-libs decision.
Neither am I.
-
PR Comment: https://git.openjdk.org/jdk/pull/23117#issuecomment-2597058064
On Wed, 15 Jan 2025 21:26:49 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Change W
On Thu, 16 Jan 2025 20:38:40 GMT, David Holmes wrote:
> Maybe I'm missing some subtlety here but shouldn't these special names always
> fail on all Windows versions, so we just need to check Platform.isWindows()
> from the test library?
There was a change in Windows 11 as to which special name
On Wed, 15 Jan 2025 21:26:49 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Change W
On Wed, 15 Jan 2025 21:26:49 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Change W
On Tue, 14 Jan 2025 22:15:07 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Minor cl
> Fix the means of determining whether an exception is to be expected in the
> Windows test.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8347740: Change Windows exceptionExpected to be based on build number
-
Ch
On Wed, 15 Jan 2025 07:19:12 GMT, David Holmes wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8347740: Minor clean up
>
> test/jdk/java/io/File/createTempFile/SpecialTempFile.java line 117:
>
>> 115:
>> 116:
On Wed, 15 Jan 2025 16:56:57 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/File/createTempFile/SpecialTempFile.java line 117:
>>
>>> 115:
>>> 116: String[] nameElements = osName.split(" ");
>>> 117: int nameVers =
>>> Integer.valueOf(nameElements[nameElements.length - 1]);
>
On Tue, 14 Jan 2025 22:15:07 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Minor cl
> Fix the means of determining whether an exception is to be expected in the
> Windows test.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8347740: Minor clean up
-
Changes:
- all: https://git.openjdk.org/jdk/pu
On Tue, 14 Jan 2025 21:47:06 GMT, Brian Burkhalter wrote:
> Fix the means of determining whether an exception is to be expected in the
> Windows test.
The test has been verified to pass on Windows 10 and 11 and on Windows Server
2016, 2019, and 2022.
-
PR Comment: https://git.ope
Fix the means of determining whether an exception is to be expected in the
Windows test.
-
Commit messages:
- 8347740: java/io/File/createTempFile/SpecialTempFile.java failing
Changes: https://git.openjdk.org/jdk/pull/23117/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=2
24 matches
Mail list logo
