On Wed, 15 Jan 2025 21:26:49 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Change Windows exceptionExpected to be based on build number
test/jdk/java/io/File/createTempFile/SpecialTempFile.java line 95:
> 93:
> 94: String cmd = "Systeminfo";
> 95: Process p = Runtime.getRuntime().exec(new String[] {cmd});
I'm not a big fan of running third-party tools in our tests; did you try fixing
the regex expression?
Replace: `"^.*[11|2025]$"` (character class) -> `"^.*(11|2025)$"` (alternative
strings)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23117#discussion_r1919992782
