Re: RFR: 8346232: Remove leftovers of the jar --normalize feature

2024-12-16 Thread Eirik Bjørsnøs
On Sat, 14 Dec 2024 12:22:15 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes a property and a code comment > left behind after the `jar --normalize` feature was removed in JDK 14. > > The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along > with r

Re: RFR: 8346232: Remove leftovers of the jar --normalize feature

2024-12-16 Thread Justin Lu
On Sun, 15 Dec 2024 09:23:47 GMT, Alan Bateman wrote: >>> We don't usually touch the translated resources. [...] For removal then >>> it's probably okay. >> >> What's your recommendation here? Happy to revert changes to translated >> files, keeping the delete in `jar.properties`, if so desirab

Re: RFR: 8346232: Remove leftovers of the jar --normalize feature

2024-12-16 Thread Jaikiran Pai
On Sat, 14 Dec 2024 12:22:15 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes a property and a code comment > left behind after the `jar --normalize` feature was removed in JDK 14. > > The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along > with r

Re: RFR: 8346232: Remove leftovers of the jar --normalize feature

2024-12-15 Thread Alan Bateman
On Sat, 14 Dec 2024 12:22:15 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes a property and a code comment > left behind after the `jar --normalize` feature was removed in JDK 14. > > The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along > with r

Re: RFR: 8346232: Remove leftovers of the jar --normalize feature

2024-12-15 Thread Alan Bateman
On Sun, 15 Dec 2024 08:52:12 GMT, Eirik Bjørsnøs wrote: > What's your recommendation here? Happy to revert changes to translated files, > keeping the delete in `jar.properties`, if so desirable. > > This would rely on Oracle's translation update process catching the remval > and update it, ide

Re: RFR: 8346232: Remove leftovers of the jar --normalize feature

2024-12-15 Thread Eirik Bjørsnøs
On Sun, 15 Dec 2024 08:40:24 GMT, Alan Bateman wrote: >> Please review this cleanup PR which removes a property and a code comment >> left behind after the `jar --normalize` feature was removed in JDK 14. >> >> The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along >> wit

Re: RFR: 8346232: Remove leftovers of the jar --normalize feature

2024-12-15 Thread Alan Bateman
On Sat, 14 Dec 2024 12:22:15 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes a property and a code comment > left behind after the `jar --normalize` feature was removed in JDK 14. > > The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along > with r

RFR: 8346232: Remove leftovers of the jar --normalize feature

2024-12-14 Thread Eirik Bjørsnøs
Please review this cleanup PR which removes a property and a code comment left behind after the `jar --normalize` feature was removed in JDK 14. The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along with removal of Pack200 tools and APIs. This PR removes the now unused `m