On Sun, 15 Dec 2024 08:40:24 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Please review this cleanup PR which removes a property and a code comment >> left behind after the `jar --normalize` feature was removed in JDK 14. >> >> The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along >> with removal of Pack200 tools and APIs. >> >> This PR removes the now unused `main.help.opt.create.normalize` property and >> a code comment in `Main.java` referencing normalization. > > src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties line 288: > >> 286: \ -n, --normalize Normalize information in the new jar >> archive\n\ >> 287: \ after creation. This option is >> deprecated, and is\n\ >> 288: \ planned for removal in a future JDK >> release > > It does appear to be leftover from when the pack200 and the -n option were > removed. > > We don't usually touch the translated resources. Oracle updates the > translations near the end of each release for the languages supported by > Oracle JDK but there are a few translations that are probably out of date > now. For removal then it's probably okay. > We don't usually touch the translated resources. [...] For removal then it's > probably okay. What's your recommendation here? Happy to revert changes to translated files, keeping the delete in `jar.properties`, if so desirable. This would rely on Oracle's translation update process catching the remval and update it, ideally in all translations, not only those supported by Oracle JDK, right? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22751#discussion_r1885558108
