On Wed, 18 Dec 2024 16:15:51 GMT, Calvin Cheung wrote:
>> We can not return to native code here in case of an error. We should
>> terminate the process instead.
>>
>> The same should really also be done in case the call to
>> `CallStaticVoidMethod` below throws an exception. This was a leftove
On Tue, 17 Dec 2024 21:43:09 GMT, Calvin Cheung wrote:
> A simple fix for removing an unused variable in fallbacklinker.cpp. This is
> needed for building zero jvm variant on macosx-x64.
>
> Testing:
>
> - [x] tier1
> - [x] zero jvm variant build on macosx-x64
Marked as reviewed by jvernee (R
On Wed, 18 Dec 2024 11:58:37 GMT, Jorn Vernee wrote:
>> How about the following?
>>
>>
>> jint result = (*VM)->AttachCurrentThreadAsDaemon(VM, (void**) &env, NULL);
>> if (result != JNI_OK) {
>> fprintf(stderr, "do_upcall trying to attach thread returned %d", result);
>> return;
>>
On Wed, 18 Dec 2024 07:37:49 GMT, Calvin Cheung wrote:
>> Agree with David here. Generally I comment out unused code errors rather
>> than outright remove them for this very reason. Also fallbackLinker doesn't
>> seem to be a C++ file?
>
> How about the following?
>
>
> jint result = (*VM)-
On Wed, 18 Dec 2024 05:21:55 GMT, Julian Waters wrote:
>> src/java.base/share/native/libfallbackLinker/fallbackLinker.c line 168:
>>
>>> 166: // attach thread
>>> 167: JNIEnv* env;
>>> 168: (*VM)->AttachCurrentThreadAsDaemon(VM, (void**) &env, NULL);
>>
>> I think the variable should be u
On Wed, 18 Dec 2024 04:39:49 GMT, David Holmes wrote:
>> A simple fix for removing an unused variable in fallbacklinker.cpp. This is
>> needed for building zero jvm variant on macosx-x64.
>>
>> Testing:
>>
>> - [x] tier1
>> - [x] zero jvm variant build on macosx-x64
>
> src/java.base/share/nat
On Tue, 17 Dec 2024 21:43:09 GMT, Calvin Cheung wrote:
> A simple fix for removing an unused variable in fallbacklinker.cpp. This is
> needed for building zero jvm variant on macosx-x64.
>
> Testing:
>
> - [x] tier1
> - [x] zero jvm variant build on macosx-x64
Changes requested by dholmes (Re
A simple fix for removing an unused variable in fallbacklinker.cpp. This is
needed for building zero jvm variant on macosx-x64.
Testing:
- [x] tier1
- [x] zero jvm variant build on macosx-x64
-
Commit messages:
- 8346132: fallbacklinker.cpp failed compilation due to unused variabl
