On Wed, 18 Dec 2024 16:15:51 GMT, Calvin Cheung <cche...@openjdk.org> wrote:
>> We can not return to native code here in case of an error. We should >> terminate the process instead. >> >> The same should really also be done in case the call to >> `CallStaticVoidMethod` below throws an exception. This was a leftover from >> the initial implementation of this code that apparently fell through the >> cracks. >> >> Ideally we should also add a test for that so... I suggest just removing the >> unused variable in this PR for now, to get this to compile, and then I can >> file a followup issue to address the lack of error handling. > > Thanks @JornVernee. The current change is just removing the unused variable. > Could you approve it? Ok, I've filed: https://bugs.openjdk.org/browse/JDK-8346575 for addressing the error handling. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22799#discussion_r1890526290
