Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2025-01-15 Thread Chen Liang
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2025-01-15 Thread Chen Liang
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2025-01-15 Thread Scott Marlow
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2025-01-14 Thread Chen Liang
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-09 Thread Chen Liang
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-09 Thread duke
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-09 Thread Scott Marlow
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-09 Thread Chen Liang
On Thu, 5 Dec 2024 23:27:38 GMT, Scott Marlow wrote: >>> I made a quick test for this, but you might not want to include it if you >>> aim to backport this improvement to LTS releases as it uses the >>> recently-finalized ClassFile API. >> >> Excellent, I'm +1000 for adding your test, thank yo

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-09 Thread Scott Marlow
On Thu, 5 Dec 2024 23:27:38 GMT, Scott Marlow wrote: >>> I made a quick test for this, but you might not want to include it if you >>> aim to backport this improvement to LTS releases as it uses the >>> recently-finalized ClassFile API. >> >> Excellent, I'm +1000 for adding your test, thank yo

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Scott Marlow
On Thu, 5 Dec 2024 23:24:56 GMT, Scott Marlow wrote: >> I made a quick test for this, but you might not want to include it if you >> aim to backport this improvement to LTS releases as it uses the >> recently-finalized ClassFile API. >> >> >> /* >> * Copyright (c) 2024, Oracle and/or its aff

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 23:24:56 GMT, Scott Marlow wrote: >> I made a quick test for this, but you might not want to include it if you >> aim to backport this improvement to LTS releases as it uses the >> recently-finalized ClassFile API. >> >> >> /* >> * Copyright (c) 2024, Oracle and/or its aff

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Scott Marlow
On Thu, 5 Dec 2024 23:18:59 GMT, Chen Liang wrote: > I made a quick test for this, but you might not want to include it if you aim > to backport this improvement to LTS releases as it uses the > recently-finalized ClassFile API. Excellent, I'm +1000 for adding your test, thank you very much fo

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Scott Marlow
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Scott Marlow
On Thu, 5 Dec 2024 19:05:07 GMT, Scott Marlow wrote: >> Created a JBS issue https://bugs.openjdk.org/browse/JDK-8345614 for you. > >> Created a JBS issue https://bugs.openjdk.org/browse/JDK-8345614 for you. > > I'll force push once more to rename the commit to issue reference the ^ > issue. Th