Re: RFR: 8344252: SM cleanup in java.util classes [v3]

2024-12-09 Thread Roger Riggs
On Mon, 9 Dec 2024 08:58:19 GMT, Eirik Bjørsnøs wrote: >>> Seems like we could simply use >>> `Boolean.getBoolean("resource.bundle.debug")` instead? >> >> Naoto may know the history on this property. It may have been introduced for >> debugging when working on the RB implementation or maybe it

Re: RFR: 8344252: SM cleanup in java.util classes [v3]

2024-12-09 Thread Eirik Bjørsnøs
On Mon, 9 Dec 2024 07:58:35 GMT, Alan Bateman wrote: > If the former, and it was never documented, there is a lot more flexibility > to change. Fair enough. However, this SM change seems to accidentally have introduced a bug where the system property is read twice, first calling System.getProp

Re: RFR: 8344252: SM cleanup in java.util classes [v3]

2024-12-09 Thread Alan Bateman
On Sat, 7 Dec 2024 19:44:05 GMT, Eirik Bjørsnøs wrote: > Seems like we could simply use `Boolean.getBoolean("resource.bundle.debug")` > instead? Naoto may know the history on this property. It may have been introduced for debugging when working on the RB implementation or maybe it was introduc

Re: RFR: 8344252: SM cleanup in java.util classes [v3]

2024-12-07 Thread Eirik Bjørsnøs
On Fri, 15 Nov 2024 17:52:28 GMT, Roger Riggs wrote: >> Remove use of doPrivileged and SecurityManager in java.util. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Correct @see link syntax in AbstractResourceBundleProvider

Re: RFR: 8344252: SM cleanup in java.util classes [v3]

2024-11-15 Thread Roger Riggs
> Remove use of doPrivileged and SecurityManager in java.util. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Correct @see link syntax in AbstractResourceBundleProvider - Changes: - all: https://git.openjdk.org/jdk/pul

Re: RFR: 8344252: SM cleanup in java.util classes [v3]

2024-11-15 Thread Naoto Sato
On Fri, 15 Nov 2024 17:52:28 GMT, Roger Riggs wrote: >> Remove use of doPrivileged and SecurityManager in java.util. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Correct @see link syntax in AbstractResourceBundleProvider

Re: RFR: 8344252: SM cleanup in java.util classes [v2]

2024-11-15 Thread Naoto Sato
On Fri, 15 Nov 2024 16:06:41 GMT, Roger Riggs wrote: >> Remove use of doPrivileged and SecurityManager in java.util. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Applied suggestions from review comments src/java.base/sha

Re: RFR: 8344252: SM cleanup in java.util classes [v2]

2024-11-15 Thread Roger Riggs
> Remove use of doPrivileged and SecurityManager in java.util. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Applied suggestions from review comments - Changes: - all: https://git.openjdk.org/jdk/pull/22122/files -

Re: RFR: 8344252: SM cleanup in java.util classes

2024-11-14 Thread Stuart Marks
On Thu, 14 Nov 2024 22:09:59 GMT, Roger Riggs wrote: > Remove use of doPrivileged and SecurityManager in java.util. Marked as reviewed by smarks (Reviewer). I mainly wanted to look at Arrays, and I looked briefly at the other stuff too. All looks good. - PR Review: https://git.op

Re: RFR: 8344252: SM cleanup in java.util classes

2024-11-14 Thread Naoto Sato
On Thu, 14 Nov 2024 22:09:59 GMT, Roger Riggs wrote: > Remove use of doPrivileged and SecurityManager in java.util. src/java.base/share/classes/java/util/Properties.java line 952: > 950: > 951: private static void writeDateComment(BufferedWriter bw) throws > IOException { > 952: /

RFR: 8344252: SM cleanup in java.util classes

2024-11-14 Thread Roger Riggs
Remove use of doPrivileged and SecurityManager in java.util. - Commit messages: - 8344252: SM cleanup in java.util classes Changes: https://git.openjdk.org/jdk/pull/22122/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22122&range=00 Issue: https://bugs.openjdk.org/browse