On Fri, 15 Nov 2024 17:52:28 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Remove use of doPrivileged and SecurityManager in java.util. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Correct @see link syntax in AbstractResourceBundleProvider src/java.base/share/classes/java/util/ResourceBundle.java line 3657: > 3655: } > 3656: > 3657: private static final boolean TRACE_ON = Boolean.getBoolean( This update seems to have broken the tracing feature of ResourceBundle. The previous code called `GetPropertyAction::privilegedGetProperty` to get the system property "resource.bundle.debug" with a default of "false". It then used `Boolean::parseBoolean` to compare it to "true", ignoring case. The new code uses `System::getProperty` to get the same property, then calls `Boolean::getBoolean` which calls `System::getProperty` to get the value of the property which name is either "false" or the result of looking up "resource.bundle.debug" >From what I can tell, it is now not possible to enable tracing. Seems like we could simply use `Boolean.getBoolean("resource.bundle.debug")` instead? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22122#discussion_r1874554294