Re: RFR: 8343436: Regression in StackMapGenerator after JDK-8339205

2024-11-01 Thread Adam Sotona
On Fri, 1 Nov 2024 15:03:51 GMT, Adam Sotona wrote: > JDK-8339205 introduced multiple regressions in StackMapGenerator and added a > lot of new untested code. > > This patch reverts StackMapGenerator to the state before JDK-8339205 and adds > one regression test. > > Please review. > > Thank

Re: RFR: 8343436: Regression in StackMapGenerator after JDK-8339205

2024-11-01 Thread Chen Liang
On Fri, 1 Nov 2024 15:03:51 GMT, Adam Sotona wrote: > JDK-8339205 introduced multiple regressions in StackMapGenerator and added a > lot of new untested code. > > This patch reverts StackMapGenerator to the state before JDK-8339205 and adds > one regression test. > > Please review. > > Thank

RFR: 8343436: Regression in StackMapGenerator after JDK-8339205

2024-11-01 Thread Adam Sotona
JDK-8339205 introduced multiple regressions in StackMapGenerator and added a lot of new untested code. This patch reverts StackMapGenerator to the state before JDK-8339205 and adds one regression test. Please review. Thanks, Adam - Commit messages: - 8343436: Regression in Stack

Re: RFR: 8343436: Regression in StackMapGenerator after JDK-8339205

2024-11-01 Thread Adam Sotona
On Fri, 1 Nov 2024 13:50:39 GMT, Adam Sotona wrote: > This patch fixes regression in StackMapGenerator caused by JDK-8339205 + > added test. > > Please review. > > Thanks, > Adam Now I noticed 8339205 added large untested surface full of bugs. I'm closing this PR and will open a new with reve

RFR: 8343436: Regression in StackMapGenerator after JDK-8339205

2024-11-01 Thread Adam Sotona
This patch fixes regression in StackMapGenerator caused by JDK-8339205 + added test. Please review. Thanks, Adam - Commit messages: - 8343436: Regression in StackMapGenerator after JDK-8339205 Changes: https://git.openjdk.org/jdk/pull/21828/files Webrev: https://webrevs.openjdk

Re: RFR: 8343436: Regression in StackMapGenerator after JDK-8339205

2024-11-01 Thread Chen Liang
On Fri, 1 Nov 2024 13:50:39 GMT, Adam Sotona wrote: > This patch fixes regression in StackMapGenerator caused by JDK-8339205 + > added test. > > Please review. > > Thanks, > Adam Seems we need to fix all the dup methods too. `checkStack` takes a usable max index instead of an exclusive end i