On Fri, 1 Nov 2024 15:03:51 GMT, Adam Sotona <asot...@openjdk.org> wrote:
> JDK-8339205 introduced multiple regressions in StackMapGenerator and added a > lot of new untested code. > > This patch reverts StackMapGenerator to the state before JDK-8339205 and adds > one regression test. > > Please review. > > Thanks, > Adam This one test is added to cover the reported bug. However better test coverage should be always included when statically expanding existing functionality and introducing a lot of new code. It is much smaller chance to catch the bug with existing tests, when each new method is handling only very small set of cases. Also overriding fields with local variables with modified values is very bad practice. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21835#issuecomment-2452083528
