On Thu, 14 Nov 2024 19:16:34 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brough
On Fri, 15 Nov 2024 01:20:43 GMT, Chen Liang wrote:
> Looks good
Thanks, @liach , for the second review.
> src/java.base/share/classes/java/io/BufferedReader.java line 329:
>
>> 327: if (term != null) term[0] = false;
>> 328:
>> 329: bufferLoop:
>
> How do we usually
On Thu, 14 Nov 2024 19:16:34 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brough
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains nine additional
On Thu, 14 Nov 2024 16:41:12 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Change "resizble" comment in BOS
On Thu, 14 Nov 2024 13:18:03 GMT, ExE Boss wrote:
>> src/java.base/share/classes/java/io/BufferedOutputStream.java line 89:
>>
>>> 87:
>>> 88: if (getClass() == BufferedOutputStream.class) {
>>> 89: // resizable if initialSize < maxSize
>>
>> I think the comment is confusin
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Change "resizble" comment in BOS
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22
On Thu, 14 Nov 2024 11:59:47 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8343039: Remove failing getDeclaredField call from test
>> java/lang/ProcessBuilder/Basic.java
>
> src/java.base/s
On Wed, 13 Nov 2024 21:39:54 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Remove failing getDeclaredField
On Wed, 13 Nov 2024 21:39:54 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Remove failing getDeclaredField
On Wed, 13 Nov 2024 19:42:29 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8343039: Remove JavaIOPrint{Stream,Writer}Access and the use thereof
>
> src/java.base/share/classes/java/io/Buffer
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Remove failing getDeclaredField call from test
java/lang/ProcessBuilder/Basic.java
-
Ch
On Wed, 13 Nov 2024 19:00:36 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Remove JavaIOPrint{Stream,Writer
On Wed, 13 Nov 2024 20:22:30 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8343039: Remove java.base/jdk.internal.misc from @modules in test
>> java/lang/ProcessBuilder/Basic.java
>
> test/
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Remove java.base/jdk.internal.misc from @modules in test
java/lang/ProcessBuilder/Basic.java
---
On Wed, 13 Nov 2024 20:16:44 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Remove InternalLock reference fr
On Wed, 13 Nov 2024 20:07:59 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Address reviewer comments
f5548
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Remove InternalLock reference from
java/lang/ProcessBuilder/Basic.java
-
Changes:
- a
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Address reviewer comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22048/fil
On Wed, 13 Nov 2024 19:57:39 GMT, Alan Bateman wrote:
> [...] it's good that Chen is reviewing too as would be too easy to introduce
> a bug with this refactor.
Definitely on both counts.
> src/java.base/share/classes/java/io/BufferedInputStream.java line 242:
>
>> 240: initialSize =
On Wed, 13 Nov 2024 19:00:36 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Remove JavaIOPrint{Stream,Writer
On Wed, 13 Nov 2024 07:15:15 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/io/BufferedOutputStream.java line 88:
>>
>>> 86: }
>>> 87:
>>> 88: this.buf = new byte[initialSize]; // resizable if initialSize <
>>> maxSize
>>
>> Same remark as for BIS.
>>
>> Also th
On Wed, 13 Nov 2024 19:00:36 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Remove JavaIOPrint{Stream,Writer
On Wed, 13 Nov 2024 16:08:51 GMT, Brian Burkhalter wrote:
> I don't mind if JavaIOPrintStreamAccess is removed now or in a later PR.
It is removed by d3d1e3a.
-
PR Comment: https://git.openjdk.org/jdk/pull/22048#issuecomment-2474479043
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Remove JavaIOPrint{Stream,Writer}Access and the use thereof
-
Changes:
- all: https://
On Tue, 12 Nov 2024 21:45:41 GMT, Brian Burkhalter wrote:
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
21c9c5e addresses reviewer comments above and removes `InternalLock`. I will
submit on more commit to remove `JavaIOPrint{Stream,Writer}Access`.
-
PR Co
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Remove use of InternalLock from Stream{De,En}coder and throwable;
remove InternalLock class; address
On Wed, 13 Nov 2024 16:55:16 GMT, Alan Bateman wrote:
> > `InternalLock` is also in `sun.nio.cs.Stream{De,En}coder`.
>
> Yes, these two will need to be updated. I don't mind if this is split up into
> several PRs but if InternalLock isn't removed by the current PR then you'll
> need to change
On Wed, 13 Nov 2024 16:14:11 GMT, Brian Burkhalter wrote:
> `InternalLock` is also in `sun.nio.cs.Stream{De,En}coder`.
Yes, these two will need to be updated. I don't mind if this is split up into
several PRs but if InternalLock isn't removed by the current PR then you'll
need to change its ti
On Wed, 13 Nov 2024 16:08:51 GMT, Brian Burkhalter wrote:
> I think we should remove jdk.internal.misc.InternalLock
`InternalLock` is also in `sun.nio.cs.Stream{De,En}coder`.
-
PR Comment: https://git.openjdk.org/jdk/pull/22048#issuecomment-2474077686
On Wed, 13 Nov 2024 07:13:30 GMT, Alan Bateman wrote:
> I think we should remove jdk.internal.misc.InternalLock and the usages in
> Throwable as part of this change. I don't mind if JavaIOPrintStreamAccess is
> removed now or in a later PR.
I will address these items first and then the other c
On Tue, 12 Nov 2024 21:45:41 GMT, Brian Burkhalter wrote:
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
I think we should remove jdk.internal.misc.InternalLock and the usages in
Throwable as part of this change. I don't mind if JavaIOPrintStreamAccess is
removed now or
On Wed, 13 Nov 2024 03:11:41 GMT, Chen Liang wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> src/java.base/share/classes/java/io/BufferedOutputStream.java line 88:
>
>> 86: }
>> 87:
>> 88: this.buf = new byte[initialSize]; // resizable if initi
On Tue, 12 Nov 2024 21:45:41 GMT, Brian Burkhalter wrote:
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
https://github.com/openjdk/jdk/tree/5212535a276a92d96ca20bdcfccfbce956febdb1 is
a baseline for before virtual threads were integrated. Note that in this
period, the
On Wed, 13 Nov 2024 02:41:05 GMT, ExE Boss wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> src/java.base/share/classes/java/io/BufferedInputStream.java line 241:
>
>> 239: }
>> 240: initialSize = size;
>> 241: buf = new byte[size];
>
>
On Tue, 12 Nov 2024 21:45:41 GMT, Brian Burkhalter wrote:
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
src/java.base/share/classes/java/io/BufferedInputStream.java line 241:
> 239: }
> 240: initialSize = size;
> 241: buf = new byte[size];
This
On Tue, 12 Nov 2024 21:45:41 GMT, Brian Burkhalter wrote:
> Uses of `InternalLock` are removed and `sycnhronized` is reinstated.
Dynamic buffer resizing in `BufferedOutputStream` and `BufferedWriter` is
retained.
The `jdk.internal.access` classes `JavaIOPrintStreamAccess` and
`JavaIOPrintWrit
Uses of `InternalLock` are removed and `sycnhronized` is reinstated.
-
Commit messages:
- 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io
Changes: https://git.openjdk.org/jdk/pull/22048/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22048&range=00
38 matches
Mail list logo
